-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move: bump Move.lock files in framework packages #15194
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
@@ -21,6 +21,7 @@ Move.lock | |||
!crates/sui-framework/packages/move-stdlib/Move.lock | |||
!crates/sui-framework/packages/sui-framework/Move.lock | |||
!crates/sui-framework/packages/sui-system/Move.lock | |||
!crates/sui-framework/packages/deepbook/Move.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we track other packages in sui-framework
so deepbook
should be included as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems fine to me, but does this mean that moving forward we'll need to make this part of the release process or something? (i.e. how does toolchain versioning work for system packages?)
Good question, I'm running into some of this with the implementation too. Let me fold that into a larger discussion that I'll raise in slack. My overall take is: if we verify against on-chain system packages, it would imply we're using the latest version (and we can bake that into our versioning implementation with or without checking Right now, if #15166 goes live, system package builds will modify |
Got it, thanks for the context! If we do go down the route of checking in these changes, we should probably also have a CI check (or update the existing |
11717f2
to
b9306f2
Compare
a745906
to
bc5264b
Compare
## Description As in title ## Test Plan N/A --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Description
Stacked on #15166.
Ran
sui move build
inframework-packages
.Test Plan
N/A
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes