[cli] Validate alias #15307
Merged
[cli] Validate alias #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
requested review from
amnn
and removed request for
patrickkuo and
joyqvq
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
7 tasks
|
@stefan-mysten is attempting to deploy a commit to the Sui Foundation Team on Vercel. A member of the Team first needs to authorize it. |
stefan-mysten
commented
Dec 12, 2023
| @@ -82,18 +82,7 @@ pub trait AccountKeystore: Send + Sync { | |||
| bail!("The provided alias {old_alias} does not exist"); | |||
| } | |||
| let new_alias_name = match new_alias { | |||
| Some(x) => { | |||
There was a problem hiding this comment.
This whole logic is moved into its own function below.
gdanezis
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description Introduce a validation step when creating or updating an alias. The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_). ## Test Plan Updated existing tests. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Added a validation step for alias naming when creating or updating the alias of an address in the Sui CLI. The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a validation step when creating or updating an alias. The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_).
Test Plan
Updated existing tests.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Added a validation step when creating or updating an alias of an address in the Sui CLI. The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_).