Db permissionless #15509
Closed
Db permissionless #15509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
@johnjmartin is attempting to deploy a commit to the Sui Foundation Team on Vercel. A member of the Team first needs to authorize it. |
* clean up download-db-snapshot code path * support ObjectStoreGetExt in download_db_snapshot codepath * add utils for manifest file read/write
johnjmartin
force-pushed
the
db-permissionless
branch
from
c641ad5
to
d0f05a5
Compare
sadhansood
reviewed
Jan 9, 2024
johnjmartin
force-pushed
the
db-permissionless
branch
from
5137021
to
d71d828
Compare
johnjmartin
force-pushed
the
db-permissionless
branch
from
d71d828
to
c4894d3
Compare
7 tasks
johnjmartin
added a commit
that referenced
this pull request
Jan 11, 2024
…15494) ## Description ~Removes `--skip-checkpoints`, `--formal`, `--verify`, and `--genesis`, from the `download-db-snapshot` command~ ``` ToolCommand::DownloadDBSnapshot { epoch, path, skip_indexes, num_parallel_downloads, network, snapshot_bucket, snapshot_bucket_type, snapshot_path, no_sign_request, # support TODO verbose, } ``` **Adds**: `download-formal-snapshot` as a future replacement for the `--formal` flag. ## Test Plan Tested with both formal snapshot and db snapshot changes via: #15509 --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Breaking change for the `sui-tool` command. This breaks the `sui-tool download-db-snapshot` into `sui-tool download-db-snapshot` and `sui-tool download-formal-snapshot` commands
|
Replaced by: #15690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to: #15494
Add support for permissionless downloads to download-db-snapshot
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes