add more optional args to dev inspect on fullnode #15679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
3fd4e5a
to
153b872
Compare
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
153b872
to
690eec6
Compare
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
690eec6
to
9a0a47e
Compare
amnn
reviewed
Jan 12, 2024
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
37d034e
to
1e04c1e
Compare
emmazzz
changed the title
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
1e04c1e
to
df03fd5
Compare
amnn
approved these changes
Jan 15, 2024
crates/sui-core/src/authority.rs
Outdated
Comment on lines
1706
to
1713
| } else { | ||
| if transaction.gas().is_empty() { |
There was a problem hiding this comment.
nit: collapse the else and if here?
| transaction.gas().to_vec() | ||
| }; | ||
|
|
||
| let (gas_status, checked_input_objects) = if skip_checks { |
There was a problem hiding this comment.
There seems to be some interesting nuances between the interfaces for these various kinds of check (e.g. some of these APIs seem to expect the gas object in the inputs, some not, etc etc). It's probably something we can simplify (later), but for now, can you add some comments to this part to call out those differences?
There was a problem hiding this comment.
Yup, this is precisely why I did not collapse the else and if - not collapsing them would make the conditions more clear and code more readable imo. I'll add some comments explaining this.
Comment on lines
+304
to
+305
| gas_price.map(|i| *i), | ||
| gas_budget.map(|i| *i), |
There was a problem hiding this comment.
Could this be done with .copied?
Suggested change
| gas_price.map(|i| *i), | |
| gas_budget.map(|i| *i), | |
| gas_price.copied(), | |
| gas_budget.copied(), |
There was a problem hiding this comment.
The map here is for converting an Option<BigInt<u64>> to an Option<u64>.
| gas_budget.map(|i| *i), | ||
| gas_sponsor, | ||
| gas_objects, | ||
| epoch.map(|i| *i), |
emmazzz
force-pushed
the
emma/refactor-dry-run
branch
from
a8ae7f8
to
a986649
Compare
7 tasks
emmazzz
added a commit
that referenced
this pull request
Jan 19, 2024
## Description This PR makes two changes: - Added an option to dev inspect arguments to return the raw transaction data. This is needed to implement dry run from graphql side. - In a previous PR #15679 , I started using the unused `epoch` parameter as transaction expiration epoch for dev inspect, which is apparently wrong. This `epoch` was supposed to be for running a txn in a previous epoch, which was never implemented. So this PR reverted that change and kept ignoring `epoch`. ## Test Plan Existing tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Added an option to return raw transaction data for dev inspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For graphql we would like to combine dry run and dev inspect functionality, and any behavior difference between the two should be made toggleable via user provided options, which will look a lot like the newly added struct
DevInspectArgsin this PR. This PR modifies the dev inspect code to make implementing new dev inspect easier. It also adds optional additional args to dev inspect APIs.Test Plan
existing tests
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
Add optional additional parameters to
dev_inspect_transaction_blockincluding gas_budget, gas_objects, gas_sponsor and skip_checks.