add option to return raw txn effects on fullnode #15729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
longbowlu
reviewed
Jan 17, 2024
| @@ -120,6 +122,7 @@ impl SuiTransactionBlockResponseOptions { | |||
| show_events: true, | |||
| show_object_changes: true, | |||
| show_balance_changes: true, | |||
| show_raw_effects: true, | |||
There was a problem hiding this comment.
this will break existing clients that use full_content, because they will get unexpected raw_effects?
There was a problem hiding this comment.
What do you recommend then? To have show_raw_effects: false here? Then it's not longer full content..
There was a problem hiding this comment.
yeah this wasn't written in a way that is future proof unfortunately. But from (existing) users' perspective, if they don't expect this field, it's fine to mark it as false. We can add a special comment explaining it
There was a problem hiding this comment.
Addressed in the latest commit.
longbowlu
approved these changes
Jan 17, 2024
emmazzz
force-pushed
the
emma/add-raw-fx
branch
from
a205f6f
to
7d7cf97
Compare
emmazzz
force-pushed
the
emma/add-raw-fx
branch
from
7d7cf97
to
234af0a
Compare
emmazzz
force-pushed
the
emma/add-raw-fx
branch
from
234af0a
to
5fb2c7e
Compare
wlmyng
pushed a commit
that referenced
this pull request
Jan 19, 2024
## Description Add an option to return raw transaction effects via transaction execution api on fullnode so that graphql can use it. See discussion on the gql PR #15717. ## Test Plan Existing tests --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Add an option to SuiTransactionBlockResponseOptions to return the raw transaction effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to return raw transaction effects via transaction execution api on fullnode so that graphql can use it. See discussion on the gql PR #15717.
Test Plan
Existing tests
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
Adds an option to
SuiTransactionBlockResponseOptionsto return the raw transaction effects.