[cli] Fix issues with showing the output for a transaction #16190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d tabled panics) when there is no input or command for the PTB
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
approved these changes
Feb 11, 2024
| } | ||
| SuiCallArg::Object(SuiObjectArg::Receiving { object_id, .. }) => { | ||
| builder.push_record(vec![format!("{i:<3} Receiving Object ID: {}", object_id)]); | ||
| if !inputs.is_empty() { |
There was a problem hiding this comment.
Nit: may be nicer to phrase this change in terms of something like
if inputs.is_empty() { return write!(EMPTY CASE...} and then the rest of the code can stay the same. But fine with it as-is as well.
There was a problem hiding this comment.
right, will do that! Thanks
There was a problem hiding this comment.
Well, there are two tables being built, so returning early will not allow the second table (commands) to be built.
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Feb 11, 2024
…s#16190) ## Description This fixes the panic that tabled throws when trying to show the output for a transaction that has no inputs or commands. (e.g., calling `client call --package 0x2 --module kiosk --function default`). ## Test Plan Existing tests, manual test. Before: ``` thread 'main' panicked at /Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs:25:18: index out of bounds: the len is 0 but the index is 0 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 2024-02-11T03:33:37.781716Z ERROR telemetry_subscribers: panicked at /Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs:25:18: index out of bounds: the len is 0 but the index is 0 panic.file="/Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs" panic.line=25 panic.column=18 ``` After: ``` Transaction Digest: ANmDQptNpb72oGKgb4Wygq9uFDWLxJwPAo865e75kP8N ╭─────────────────────────────────────────────────────────────────────────────────────────────╮ │ Transaction Data │ ├─────────────────────────────────────────────────────────────────────────────────────────────┤ │ Sender: 0x0fe375fff0ee40d20c54a7f2478b9b5c7eaa3625b7611f9661ec5faefb4a6fea │ │ Gas Owner: 0x0fe375fff0ee40d20c54a7f2478b9b5c7eaa3625b7611f9661ec5faefb4a6fea │ │ Gas Budget: 1000000000 MIST │ │ Gas Price: 1000 MIST │ │ Gas Payment: │ │ ┌── │ │ │ ID: 0x1270f13fabe5a1622179827643e8d0989a689a2dfb2e0ff74e97685186159c73 │ │ │ Version: 17 │ │ │ Digest: 2DTL2j9YGvy92AUhd5ECzx3jGLCk98VA4muvWqu4A4xs │ │ └── │ │ │ │ Transaction Kind: Programmable │ │ No input objects for this transaction │ │ ╭──────────────────────────────────────────────────────────────────────────────────╮ │ │ │ Commands │ │ │ ├──────────────────────────────────────────────────────────────────────────────────┤ │ │ │ 0 MoveCall: │ │ │ │ ┌ │ │ │ │ │ Function: default │ │ │ │ │ Module: kiosk │ │ │ │ │ Package: 0x0000000000000000000000000000000000000000000000000000000000000002 │ │ │ │ └ │ │ │ ╰──────────────────────────────────────────────────────────────────────────────────╯ │ │ │ │ Signatures: │ │ +OOZ8uwjS+XK3sz0TyMf19d6ouwLSfqiF57jSFxkH0KNJN2c9tDebN3JrqEHXV6wzON492THldd95oLDW+6UBA== │ │ │ ╰─────────────────────────────────────────────────────────────────────────────────────────────╯ ``` --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Fixed the CLI to handle the table output for a transaction that has no inputs or commands. (e.g., calling `client call --package 0x2 --module kiosk --function default`).
stefan-mysten
added a commit
that referenced
this pull request
Feb 12, 2024
…16193) ## Description This fixes the panic that tabled throws when trying to show the output for a transaction that has no inputs or commands. (e.g., calling `client call --package 0x2 --module kiosk --function default`). ## Test Plan Existing tests, manual test. Before: ``` thread 'main' panicked at /Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs:25:18: index out of bounds: the len is 0 but the index is 0 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 2024-02-11T03:33:37.781716Z ERROR telemetry_subscribers: panicked at /Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs:25:18: index out of bounds: the len is 0 but the index is 0 panic.file="/Users/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tabled-0.15.0/src/grid/records/records_mut.rs" panic.line=25 panic.column=18 ``` After: ``` Transaction Digest: ANmDQptNpb72oGKgb4Wygq9uFDWLxJwPAo865e75kP8N ╭─────────────────────────────────────────────────────────────────────────────────────────────╮ │ Transaction Data │ ├─────────────────────────────────────────────────────────────────────────────────────────────┤ │ Sender: 0x0fe375fff0ee40d20c54a7f2478b9b5c7eaa3625b7611f9661ec5faefb4a6fea │ │ Gas Owner: 0x0fe375fff0ee40d20c54a7f2478b9b5c7eaa3625b7611f9661ec5faefb4a6fea │ │ Gas Budget: 1000000000 MIST │ │ Gas Price: 1000 MIST │ │ Gas Payment: │ │ ┌── │ │ │ ID: 0x1270f13fabe5a1622179827643e8d0989a689a2dfb2e0ff74e97685186159c73 │ │ │ Version: 17 │ │ │ Digest: 2DTL2j9YGvy92AUhd5ECzx3jGLCk98VA4muvWqu4A4xs │ │ └── │ │ │ │ Transaction Kind: Programmable │ │ No input objects for this transaction │ │ ╭──────────────────────────────────────────────────────────────────────────────────╮ │ │ │ Commands │ │ │ ├──────────────────────────────────────────────────────────────────────────────────┤ │ │ │ 0 MoveCall: │ │ │ │ ┌ │ │ │ │ │ Function: default │ │ │ │ │ Module: kiosk │ │ │ │ │ Package: 0x0000000000000000000000000000000000000000000000000000000000000002 │ │ │ │ └ │ │ │ ╰──────────────────────────────────────────────────────────────────────────────────╯ │ │ │ │ Signatures: │ │ +OOZ8uwjS+XK3sz0TyMf19d6ouwLSfqiF57jSFxkH0KNJN2c9tDebN3JrqEHXV6wzON492THldd95oLDW+6UBA== │ │ │ ╰─────────────────────────────────────────────────────────────────────────────────────────────╯ ``` --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Fixed the CLI to handle the table output for a transaction that has no inputs or commands. (e.g., calling `client call --package 0x2 --module kiosk --function default`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the panic that tabled throws when trying to show the output for a transaction that has no inputs or commands. (e.g., calling
client call --package 0x2 --module kiosk --function default).Test Plan
Existing tests, manual test.
Before:
After:
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
The CLI now properly handles the table output for a transaction that has no inputs or commands. For example, calling
client call --package 0x2 --module kiosk --function defaultnow has a properly formatted output.