[move-2024] Change default TOML to be 2024 beta #16697
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@cgswords can you hold off on merging this? I think if today someone started using this, and tries to publish a 2024.beta edition it is going to fail dependency verification on sui framework packages (because it is going to compile the current sui framework with 2024.beta, which I think mismatches the current on-chain bytecode).
I need to double check things here and come up with a way to resolve if it's the case. As mentioned in our talk, we don't currently version compilation of sui framework packages, and always choose the current compiler. I may need to revisit how that works if we are enabling 2024.beta but don't yet publish sui framework packages to chain with 2024.beta.
|
In fact this change should probably come with an integration test that does something like I will help with that--I have a hunch I will need to make a change to toolchain versioning code before that "just works". |
Okay there's no mismatch, I was checking different changes locally (localnet vs testnet). Still, think it's worthwhile to have a test here, will see if I can tack on a commit to this PR! |
|
On second thought--clarified with @cgswords I missed that |
The change in MystenLabs/sui#16697 released on April 2 defaults to a newer version of Move that does not compile the token contract created by the backend.
The change in MystenLabs/sui#16697 released on April 2 defaults to a newer version of Move that does not compile the token contract created by the backend.
## Description Change default TOML to be 2024 beta ## Test Plan Local testing, plus other tests still work. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Changes the default `Move.toml` for `sui move new` and `move new` to use the Move 2024 beta release.
The change in MystenLabs/sui#16697 released on April 2 defaults to a newer version of Move that does not compile the token contract created by the backend.
Description
Change default TOML to be 2024 beta
Test Plan
Local testing, plus other tests still work.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
When using the
sui move newormove newcommands, the defaultMove.tomlfile created is formatted to work with Move 2024 beta release. Move 2024 beta release adds some functionality to the core Move language but is opt-in, so legacy code will continue to run as expected.