Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] Needless else #16874

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tx-tomcat
Copy link
Contributor

@tx-tomcat tx-tomcat commented Mar 26, 2024

Description

Detects empty else branches in conditional structures, suggesting their removal for cleaner code.
Aims to flag potentially unnecessary or unimplemented placeholders within if-else statements.
Encourages code clarity and maintainability by eliminating redundant branches.

Run the linter

cargo test move_check_testsuit

Testing

File testing: needless_else.move

Release notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 3:59pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 3:59pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 3:59pm
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 3:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 3:59pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 3:59pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 3:59pm

Copy link

vercel bot commented May 31, 2024

@tx-tomcat is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants