Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: level2 book status validation #16919

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: level2 book status validation #16919

merged 2 commits into from
Mar 28, 2024

Conversation

leecchh
Copy link
Contributor

@leecchh leecchh commented Mar 28, 2024

Description

Validation for get_level2_book_status_bid(ask)_side for price_low, price_high inputs.

Test Plan

How did you test the new or updated feature?

Testnet deepbook pool testing


If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Provides a more precise rounding calculation in Deepbook accessor function (read only) that returns level 2 book data within a price range.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:10pm

Copy link
Contributor

@0xaslan 0xaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this would fix the issue.

I am wondering how frequent prod fixes for Deepbook look from the outside? Would users or malicious players think the protocol has weaknesses?

@leecchh
Copy link
Contributor Author

leecchh commented Mar 28, 2024

LGTM, this would fix the issue.

I am wondering how frequent prod fixes for Deepbook look from the outside? Would users or malicious players think the protocol has weaknesses?

@manolisliolios Do you have context on this? Curious as well

Copy link
Contributor

@ronny-mysten ronny-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The md change is autogen'd, so that part lgtm.

@leecchh leecchh merged commit f2651e9 into main Mar 28, 2024
75 checks passed
@leecchh leecchh deleted the tlee/deepbook-fix branch March 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants