Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert deepbook l2 update #17126

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: revert deepbook l2 update #17126

merged 1 commit into from
Apr 11, 2024

Conversation

leecchh
Copy link
Contributor

@leecchh leecchh commented Apr 11, 2024

Description

Reverting change to L2 accessor in Deepbook causing error for market makers.

Test plan

How did you test the new or updated feature?

Reverting changes, no testing needed.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Deepbook changes will be reverted
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Apr 11, 2024 3:54pm
sui-kiosk ⬜️ Ignored (Inspect) Apr 11, 2024 3:54pm
sui-typescript-docs ⬜️ Ignored (Inspect) Apr 11, 2024 3:54pm

Copy link
Contributor

@0xaslan 0xaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving reverting these changes. Imo this was very minor in the first place that nobody complained about. It would be a better use of time if we focus on V3.

@leecchh leecchh merged commit 5789a7f into main Apr 11, 2024
44 checks passed
@leecchh leecchh deleted the tlee/revert-deepbookl2 branch April 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants