[indexer] primary key of tx_calls should include module and func #17602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
I suppose this one needs a backfill so I've created a new breaking change branch as the base branch of this PR. |
wlmyng
approved these changes
May 9, 2024
gegaowp
approved these changes
May 9, 2024
|
the primary key info is also in the schema/pg.rs, so we will want to make a corresponding change there too. |
|
no strong opinion, but I also updated the branch https://github.com/MystenLabs/sui/commits/idx-breaking-change-park and we can continue using that for the next batch of backfill & deployment. |
emmazzz
changed the base branch from
idx-breaking-change-may-2024
to
idx-breaking-change-park
amnn
pushed a commit
that referenced
this pull request
May 14, 2024
) ## Description One transaction can call multiple functions in a package so the primary key should include all parts of a function - package, module, func. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [x] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
emmazzz
added a commit
that referenced
this pull request
Jun 20, 2024
) ## Description One transaction can call multiple functions in a package so the primary key should include all parts of a function - package, module, func. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [x] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
emmazzz
added a commit
that referenced
this pull request
Aug 3, 2024
) ## Description One transaction can call multiple functions in a package so the primary key should include all parts of a function - package, module, func. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [x] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One transaction can call multiple functions in a package so the primary key should include all parts of a function - package, module, func.
Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.