[pick] indexer: uhaul breaking changes from park to main (#17439) #17605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)"" This reverts commit c47b362.
For event and object types stored in the indexer tables, this PR stores the `package`, `module` and `name` of the `StructTag` in addition to the full type information. With this change all the queries we do to filter by type in graphql will be exact match instead of using `LIKE`. I chose to go with still keeping the full type field for backward compatibility (since indexer and gql are on different release schedules), testability (so we can easily test performance difference using the old and new way against the same db) and simplicity (so we don't need to worry too much about type params). Existing graphql tests and added indexer ingestion tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration
## Description the original intention was to partition tx_ tables such that they can be easily pruned by dropping old partitions, however that indicates that for each query with a "lookup key" like sender, we will have to scan all partitions, which can be costly. also after pulling the numbers from DB, the sizes of these tables are relatively small and thus we can take the extra storage for now in favor of reading side perf. ## Test plan benchmark and experiment --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
7 tasks
amnn
merged commit 109cf8b
into
releases/sui-graphql-rpc-v2024.4.0-release
46 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick schema changes that were recently landed in
mainfor the indexer to the 2024.4 release branch.Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.