Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphQL][EASY] Remove MovePackage.checkpoint_viewed_at #17691

Merged
merged 3 commits into from
May 14, 2024
Merged

[GraphQL][EASY] Remove MovePackage.checkpoint_viewed_at #17691

merged 3 commits into from
May 14, 2024

Commits on May 14, 2024

  1. [Indexer/TiDB] Standardize prefix lengths for blob indices 

    ## Description

Pick standard prefix lengths for well-known types that make good use
of details we know about their structure:

- Object IDs, addresses and digests are all 32 byte quantities.
- Move Identifiers cannot be larger than 128 bytes.
- Fully-qualified types are unlikely to be more than 256 bytes (this
  is the only case where we have to approximate).

## Test plan

```
sui-indexer$ diesel database reset --database-url=$DB --migration-dir='migrations/mysql'
sui-indexer$ cargo run                           \
  --no-default-features --features mysql-feature \
  -- --db-url $DB --reset-db                     \
  --fullnode-sync-worker                         \
  --rpc-client-url "$MAINNET"
```

Ensure data being filled from mainnet by the indexer is well-formed.
    @amnn
    amnn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d6d0752 View commit details
    Browse the repository at this point in the history

  2. [Indexer/Schema] Remove query cost function 

    ## Description

We no longer use the query_cost function anywhere (it has been
replaced by a diesel extension that enables us to call `EXPLAIN` on a
query), so cleaning it up to avoid having to maintain it (and create a
MySQL compatible version of it).

## Test plan

```
sui-indexer$ diesel setup --database-url=$DB --migration-dir='migrations/mysql'
sui-indexer$ diesel database reset --database-url=$DB --migration-dir='migrations/mysql'
sui$ cargo nextest run -p sui-indexer
sui$ cargo nextest run -p sui-graphql-rpc
sui$ cargo nextest run -p sui-graphql-e2e-tests --features pg_integration
```
    @amnn
    amnn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5cb39a5 View commit details
    Browse the repository at this point in the history

  3. [GraphQL][EASY] Remove MovePackage.checkpoint_viewed_at 

    ## Description

The same data is available as
`MovePackage.super_.checkpoint_viewed_at` and has been exposed as
`MovePackage.checkpoint_viewed_at_impl()`.

## Test plan

```
sui$ cargo nextest run -p sui-graphql-e2e-tests --features pg_integration
```
    @amnn
    amnn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a2a281d View commit details
    Browse the repository at this point in the history