Fix no-op pruner setting #17928
Merged
Fix no-op pruner setting #17928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@halfprice is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
halfprice
force-pushed
the
zhewu/pruner-setting-wrapped-tombstone
branch
from
e38ee96
to
1428ac5
Compare
mystenmark
approved these changes
May 24, 2024
crates/sui-node/src/lib.rs
Outdated
| @@ -587,13 +587,16 @@ impl SuiNode { | |||
| state_snapshot_handle.is_some(), | |||
| )?; | |||
|
|
|||
| let mut pruning_config = config.authority_store_pruning_config; | |||
| // `genesis` is immutably borrowed from config. So we have to clone a copy here. | |||
| let mut config = config.clone(); | |||
There was a problem hiding this comment.
this is so clever i thought it re-introduces the bug.
You could just clone genesis above, which might be less confusing? up to you
There was a problem hiding this comment.
Yeah, I was debating. I cloned genesis above, and hope that no one clone the genesis from config agian and modify it
There was a problem hiding this comment.
modifying genesis is very unlikely (unless we are trying to inject a failure or something) so this seems better
halfprice
added a commit
to halfprice/sui
that referenced
this pull request
May 25, 2024
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.