Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] fix command sui keytool import using --alias is useless when inputting mnemonic phrase #17935

Merged
merged 17 commits into from
May 28, 2024

Conversation

bityoume
Copy link
Contributor

@bityoume bityoume commented May 25, 2024

Description

[CLI] fix command sui keytool import using --alias is useless when inputting mnemonic phrase

2x

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: Fixed a bug where the provided alias in the sui keytool import command was not kept when importing a key via mnemonic.
  • Rust SDK:

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 2:20pm

Copy link

vercel bot commented May 25, 2024

@bityoume is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

@stefan-mysten
Copy link
Contributor

Thanks @bityoume, keep'em coming.

@stefan-mysten stefan-mysten merged commit 80b8d95 into MystenLabs:main May 28, 2024
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants