Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] fix sui keytool zk-login-sign-and-execute-tx command bug #17989

Merged
merged 20 commits into from
Jun 1, 2024

Conversation

bityoume
Copy link
Contributor

@bityoume bityoume commented May 30, 2024

Description

[CLI] fix sui keytool zk-login-sign-and-execute-tx command bug

image

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: Fixed the code to ensure it has a gas coin for the sui keytool zk-login-sign-and-execute-tx command.
  • Rust SDK:

Copy link

vercel bot commented May 30, 2024

@bityoume is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 4:52am

@stefan-mysten
Copy link
Contributor

Thanks @bityoume. Can you also add a descriptive message for the release notes section?

@joyqvq could you have a quick look to see if this works as initially intended?

@stefan-mysten stefan-mysten self-assigned this May 30, 2024
@stefan-mysten stefan-mysten self-requested a review May 30, 2024 05:46
@joyqvq
Copy link
Contributor

joyqvq commented May 30, 2024

curious why do you need this cli ? while im ok with this change to make it more resilient, this is for our testing scaffolding to work, but it only works for devnet or localnet.

@bityoume
Copy link
Contributor Author

bityoume commented Jun 1, 2024

curious why do you need this cli ? while im ok with this change to make it more resilient, this is for our testing scaffolding to work, but it only works for devnet or localnet.

@joyqvq Because I am writing an introductory article about the SUI CLI, so I am trying out each command :)

@bityoume
Copy link
Contributor Author

bityoume commented Jun 1, 2024

Thanks @bityoume. Can you also add a descriptive message for the release notes section?

@joyqvq could you have a quick look to see if this works as initially intended?

@stefan-mysten I have already added a descriptive message for the release notes section, is that ok?

@stefan-mysten stefan-mysten merged commit 6637097 into MystenLabs:main Jun 1, 2024
41 of 44 checks passed
@stefan-mysten
Copy link
Contributor

Looks good, thanks @bityoume!

tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Jul 29, 2024
…tenLabs#17989)

## Description 

[CLI] fix `sui keytool zk-login-sign-and-execute-tx` command bug


![image](https://github.com/MystenLabs/sui/assets/123343203/559180fc-e01e-43ff-99d6-e57fe14253aa)


## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [x] CLI: Fixed the code to ensure it has a `gas coin` for the `sui
keytool zk-login-sign-and-execute-tx` command.
- [ ] Rust SDK:

---------

Co-authored-by: stefan-mysten <135084671+stefan-mysten@users.noreply.github.com>
Co-authored-by: howtosui <jasonrzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants