[consensus] Revert consensus handler change where commits from the same round are ignored #18248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mwtian
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Let's remember to revert forward after Narwhal is deprecated. I think the logic to verify no commit is skipped can be added to Mysticeti commit observer instead. The logic to ignore duplicated commits can be added to Narwhal executor too, but we probably don't want to make significant changes to Narwhal codebase anymore.
akichidis
reviewed
Jun 14, 2024
Comment on lines
+238
to
+248
| assert!(round >= last_committed_round); | ||
| if last_committed_round == round { | ||
| // we can receive the same commit twice after restart | ||
| // It is critical that the writes done by this function are atomic - otherwise we can | ||
| // lose the later parts of a commit if we restart midway through processing it. | ||
| warn!( | ||
| "Ignoring consensus output for round {} as it is already committed. NOTE: This is only expected if Narwhal is running.", | ||
| round | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I guess an alternative here would be to check which consensus engine is running and adapt the checks - or as @mwtian said offline, move the Mysticeti check in commit observer. It's still nice to have consensus_handler do a sanity check as separate component though.
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…me round are ignored (MystenLabs#18248) When Narwhal is running it is still possible on restarts to resend a commit from the same round. Mysticeti should not return more than one commit per round unless something is broken so it is okay to keep this check for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Narwhal is running it is still possible on restarts to resend a commit from the same round. Mysticeti should not return more than one commit per round unless something is broken so it is okay to keep this check for now.