Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gql][pick-2024.4.0]explicitly setup test scenario for test_query_default_page_limit (#18… #18394

Commits on Jun 25, 2024

  1. explicitly setup test scenario for test_query_default_page_limit (#18393

    )
    
    Unblock #18277 by explicitly
    setting up the correct test scenario for the
    `test_query_default_page_limit` test.
    
    I think we can follow this up with
    1. instead of using the same db url, follow sui-graphql-e2e-tests
    pattern and generate unique db urls for each test
    2. this is so that we can run tests in parallel instead of sequentially
    (which is the case today due to the serial)
    3. we can leverage ExecutorCluster.cleanup_resources to cleanup each
    test
    
    How did you test the new or updated feature?
    
    ---
    
    Check each box that your changes affect. If none of the boxes relate to
    your changes, release notes aren't required.
    
    For each box you select, include information after the relevant heading
    that describes the impact of your changes that a user might notice and
    any actions they must take to implement updates.
    
    - [ ] Protocol:
    - [ ] Nodes (Validators and Full nodes):
    - [ ] Indexer:
    - [ ] JSON-RPC:
    - [ ] GraphQL:
    - [ ] CLI:
    - [ ] Rust SDK:
    wlmyng committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ce2d273 View commit details
    Browse the repository at this point in the history