Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SIMTEST_STATIC_INIT_MOVE variable for Code Coverage #18998

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ebmifa
Copy link
Contributor

@ebmifa ebmifa commented Aug 15, 2024

Description

Set SIMTEST_STATIC_INIT_MOVE variable for Code Coverage due to #18752

Test plan

https://github.com/MystenLabs/sui/actions/runs/10406180594/job/28818615076

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 3:59pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 3:59pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 3:59pm

@ebmifa ebmifa changed the title Set SIMTEST_STATIC_INIT_MOVE variable Set SIMTEST_STATIC_INIT_MOVE variable Aug 15, 2024
@ebmifa ebmifa requested a review from halfprice August 15, 2024 15:56
@ebmifa ebmifa changed the title Set SIMTEST_STATIC_INIT_MOVE variable Set SIMTEST_STATIC_INIT_MOVE variable for Code Coverage Aug 15, 2024
@@ -11,6 +11,9 @@ fi
# apply git patch
git apply ./scripts/simtest/config-patch

root_dir=$(git rev-parse --show-toplevel)
export SIMTEST_STATIC_INIT_MOVE=$root_dir"/examples/move/basics"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halfprice and @mystenmark is this the correct dir to set? It did pass on my test run

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@@ -11,6 +11,9 @@ fi
# apply git patch
git apply ./scripts/simtest/config-patch

root_dir=$(git rev-parse --show-toplevel)
export SIMTEST_STATIC_INIT_MOVE=$root_dir"/examples/move/basics"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@ebmifa ebmifa merged commit 65843fd into main Aug 15, 2024
51 checks passed
@ebmifa ebmifa deleted the ebmifa/fix_code_coverage branch August 15, 2024 16:21
tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Aug 27, 2024
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants