-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer: upload display to GCS #19196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gegaowp
force-pushed
the
upload-display
branch
from
September 3, 2024 16:50
b208da8
to
d124894
Compare
bmwill
reviewed
Sep 4, 2024
gegaowp
force-pushed
the
upload-display
branch
from
September 4, 2024 20:58
d124894
to
92f4990
Compare
gegaowp
force-pushed
the
upload-display
branch
from
September 4, 2024 21:05
92f4990
to
7880515
Compare
bmwill
approved these changes
Sep 6, 2024
gegaowp
force-pushed
the
upload-display
branch
from
September 6, 2024 15:01
7880515
to
1fad27c
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description upload display table in csv to GCS for later restoring from there, as it's now possible to restore from formal snapshot. ## Test plan local run and verify that files are on GCS https://console.cloud.google.com/storage/browser/mysten-mainnet-display-table;tab=objects?forceOnBucketsSortingFiltering=true&hl=en&project=fullnode-snapshot-gcs&prefix=&forceOnObjectsSortingFiltering=false ![Screenshot 2024-09-03 at 12 42 29 PM](https://github.com/user-attachments/assets/d1921af2-688c-4c1b-adef-3117bf07cb03) --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [x] Indexer: need to add a cred before next deployment to enable uploading. - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upload display table in csv to GCS for later restoring from there, as it's now possible to restore from formal snapshot.
Test plan
local run and verify that files are on GCS
https://console.cloud.google.com/storage/browser/mysten-mainnet-display-table;tab=objects?forceOnBucketsSortingFiltering=true&hl=en&project=fullnode-snapshot-gcs&prefix=&forceOnObjectsSortingFiltering=false
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.