Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indexer] A few improvements to backfill tool #19441

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Sep 18, 2024

Description

This PR adds 3 improvements to the sql backfill tool:

  1. It allows ON CONFLICT DO NOTHING, so that we can safely backfill gaps without been too precise.
  2. It tunes down the default concurrency and chunk size, and allows for override through command line args.
  3. It prints out the minimum in-progress checkpoint so that if it ever stops for some reason, you can restart using that number.

Test plan

Run again locally


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 11:41pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 18, 2024 11:41pm
sui-kiosk ⬜️ Ignored (Inspect) Sep 18, 2024 11:41pm
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 18, 2024 11:41pm

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lxfind !

@lxfind lxfind merged commit b8d8194 into main Sep 19, 2024
47 of 48 checks passed
@lxfind lxfind deleted the indexer-backfill-improvements branch September 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants