[stdlib] Formats MoveStdlib package 1/N #19461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirka
requested review from
amnn,
cgswords,
awelc,
tnowacki,
tzakian,
sblackshear and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
damirka
changed the title
8 tasks
tnowacki
approved these changes
Sep 20, 2024
| bytes == &b"bool" || | ||
| module std::type_name; | ||
|
|
||
| use std::{address, ascii::{Self, String}}; |
There was a problem hiding this comment.
not sure I like the use grouping here. Strong feelings? If not, maybe revert for this PR
There was a problem hiding this comment.
It's what formatter does these days.
tnowacki
reviewed
Sep 20, 2024
Comment on lines
132
to
134
| i = i + 1; | ||
| i | ||
| }); |
There was a problem hiding this comment.
Was this auto formatted? If so, its a good bug to fix IMO :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses module label in the MoveStdlib, runs the current build of the formatter on the code.
Test plan
All tests must pass, no snapshot regen should be required.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.