Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authority_aggregator: always request for events when asked (#19251) #19467

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Sep 20, 2024

Change AuthorityAggregator to always pass through request_events flag, even to the validators we aren't sampling for objects.

In addition, up the sample size of validators to 10 and log when we get unlucky and reach quorum without having recieved input or output objects.

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 5:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 5:51pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 5:51pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 5:51pm

@bmwill bmwill enabled auto-merge (squash) September 20, 2024 17:44
Change AuthorityAggregator to always pass through request_events flag,
even to the validators we aren't sampling for objects.

In addition, up the sample size of validators to 10 and log when we get
unlucky and reach quorum without having recieved input or output
objects.
@bmwill bmwill merged commit f1bba34 into MystenLabs:releases/sui-v1.33.0-release Sep 23, 2024
43 of 45 checks passed
@bmwill bmwill deleted the releases/sui-v1.33.0-release branch September 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants