fn json rpc: retry on empty events #19469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gegaowp
force-pushed
the
fn-retry-empty-events
branch
from
77768f8
to
dae2c90
Compare
amnn
reviewed
Sep 20, 2024
gegaowp
force-pushed
the
fn-retry-empty-events
branch
from
dae2c90
to
4772918
Compare
amnn
reviewed
Sep 23, 2024
gegaowp
force-pushed
the
fn-retry-empty-events
branch
from
4772918
to
07fd683
Compare
gegaowp
force-pushed
the
fn-retry-empty-events
branch
from
07fd683
to
3f5a69d
Compare
gegaowp
force-pushed
the
fn-retry-empty-events
branch
from
3f5a69d
to
1ae7b08
Compare
bmwill
reviewed
Sep 23, 2024
bmwill
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when query transaction with showEvents set, it's possible that the transaction effects is available while events are not, as events are outputs of fn local execution, thus instead of returning empty events and make whole transaction response in-complete, we should retry, in that sense as long as fn responds, the response is complete.
Test plan
ci
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.