[bridge] Update abi #19483
Merged
[bridge] Update abi #19483
+342
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
longbowlu
force-pushed
the
update-abi
branch
from
fc36708
to
e6c108f
Compare
longbowlu
commented
Sep 21, 2024
Comment on lines
+17
to
+43
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "target", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressEmptyCode", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "account", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressInsufficientBalance", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [], | ||
| "name": "FailedInnerCall", | ||
| "type": "error" | ||
| }, |
There was a problem hiding this comment.
@Bridgerz is this expected?
There was a problem hiding this comment.
I believe these abi updates came with our newer foundry version. Shouldn't be an issue.
Comment on lines
+85
to
+100
| { | ||
| "inputs": [], | ||
| "name": "ReentrancyGuardReentrantCall", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "token", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "SafeERC20FailedOperation", | ||
| "type": "error" | ||
| }, |
There was a problem hiding this comment.
and this @Bridgerz
Comment on lines
+13
to
+23
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "account", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressInsufficientBalance", | ||
| "type": "error" | ||
| }, |
There was a problem hiding this comment.
and this @Bridgerz
Comment on lines
+140
to
+150
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "token", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "SafeERC20FailedOperation", | ||
| "type": "error" | ||
| }, |
Comment on lines
-358
to
-362
| }, | ||
| { | ||
| "internalType": "address", | ||
| "name": "_wETH", | ||
| "type": "address" |
There was a problem hiding this comment.
SuiBridge no longer has a reference to weth as the vault handles all wrapping and unwrapping. must be a stale reference to an old version.
Comment on lines
-567
to
-579
| }, | ||
| { | ||
| "inputs": [], | ||
| "name": "wETH", | ||
| "outputs": [ | ||
| { | ||
| "internalType": "contract IWETH9", | ||
| "name": "", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "stateMutability": "view", | ||
| "type": "function" |
Bridgerz
approved these changes
Sep 21, 2024
Comment on lines
+17
to
+43
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "target", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressEmptyCode", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "account", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressInsufficientBalance", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [], | ||
| "name": "FailedInnerCall", | ||
| "type": "error" | ||
| }, |
There was a problem hiding this comment.
I believe these abi updates came with our newer foundry version. Shouldn't be an issue.
Comment on lines
+85
to
+100
| { | ||
| "inputs": [], | ||
| "name": "ReentrancyGuardReentrantCall", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "token", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "SafeERC20FailedOperation", | ||
| "type": "error" | ||
| }, |
Comment on lines
+13
to
+23
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "account", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "AddressInsufficientBalance", | ||
| "type": "error" | ||
| }, |
Comment on lines
+140
to
+150
| { | ||
| "inputs": [ | ||
| { | ||
| "internalType": "address", | ||
| "name": "token", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "name": "SafeERC20FailedOperation", | ||
| "type": "error" | ||
| }, |
Comment on lines
-358
to
-362
| }, | ||
| { | ||
| "internalType": "address", | ||
| "name": "_wETH", | ||
| "type": "address" |
There was a problem hiding this comment.
SuiBridge no longer has a reference to weth as the vault handles all wrapping and unwrapping. must be a stale reference to an old version.
Comment on lines
-567
to
-579
| }, | ||
| { | ||
| "inputs": [], | ||
| "name": "wETH", | ||
| "outputs": [ | ||
| { | ||
| "internalType": "contract IWETH9", | ||
| "name": "", | ||
| "type": "address" | ||
| } | ||
| ], | ||
| "stateMutability": "view", | ||
| "type": "function" |
longbowlu
force-pushed
the
update-abi
branch
from
e6c108f
to
f2eec19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update bridge abi for the recent changes in solidity code
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.