Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version 69 and move consensus voting round flag to 69 #20199

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

arun-koshy
Copy link
Contributor

Fix for testnet compatibility test

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Sets number of rounds allowed for fastpath voting in consensus
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@arun-koshy arun-koshy requested review from ebmifa and mwtian November 6, 2024 23:33
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:22am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:22am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:22am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:22am

@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 23:33 — with GitHub Actions Inactive
@arun-koshy arun-koshy enabled auto-merge (squash) November 6, 2024 23:49
@arun-koshy arun-koshy disabled auto-merge November 7, 2024 00:01
@ebmifa
Copy link
Contributor

ebmifa commented Nov 7, 2024

@arun-koshy Still failing on this branch

eugene@eugene-dev ~/code/sui/scripts/compatibility ((HEAD detached at c023579d58)) $ ./check-protocol-compatibility.sh testnet
Found following versions on testnet:
     95 1.37.1-7839b9501066
     42 1.35.1-61e90ef385a9
      2 1.37.1-7839b95010
      2 1.35.0-08a4ef986fdf
      1 1.37.1-7839b9501066-dirty
      1 1.36.2-3ada97c109cc

Using most frequent version 1.37.1-7839b9501066 for compatibility check
Source commit: c023579d58ec2fbc279eecaa9ac9862e45eb31a0
Source branch: (HEAD detached at c023579d58)
Checking protocol compatibility with testnet (7839b9501066)
Error: Please commit or stash your changes before running this script
diff --git a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_68.snap b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_68.snap
index 4f4cb85fe3..492aebef1a 100644
--- a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_68.snap
+++ b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_68.snap
@@ -336,3 +336,4 @@ max_accumulated_txn_cost_per_object_in_mysticeti_commit: 18500000
 max_accumulated_randomness_txn_cost_per_object_in_mysticeti_commit: 3700000
 gas_budget_based_txn_cost_cap_factor: 400000
 gas_budget_based_txn_cost_absolute_cap_commit_count: 50
+
diff --git a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_68.snap b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_68.snap
index 4f4cb85fe3..492aebef1a 100644
--- a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_68.snap
+++ b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_68.snap
@@ -336,3 +336,4 @@ max_accumulated_txn_cost_per_object_in_mysticeti_commit: 18500000
 max_accumulated_randomness_txn_cost_per_object_in_mysticeti_commit: 3700000
 gas_budget_based_txn_cost_cap_factor: 400000
 gas_budget_based_txn_cost_absolute_cap_commit_count: 50
+
diff --git a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_68.snap b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_68.snap
index 6c6b5dcb39..68e5595552 100644
--- a/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_68.snap
+++ b/crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_68.snap
@@ -347,3 +347,4 @@ max_accumulated_txn_cost_per_object_in_mysticeti_commit: 18500000
 max_accumulated_randomness_txn_cost_per_object_in_mysticeti_commit: 3700000
 gas_budget_based_txn_cost_cap_factor: 400000
 gas_budget_based_txn_cost_absolute_cap_commit_count: 50

@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env November 7, 2024 00:20 — with GitHub Actions Inactive
@arun-koshy arun-koshy enabled auto-merge (squash) November 7, 2024 00:27
@arun-koshy arun-koshy merged commit 7727b16 into main Nov 7, 2024
52 checks passed
@arun-koshy arun-koshy deleted the ak/fix-compat-test branch November 7, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants