[consensus] Get highest accepted rounds from RoundProber and use in ancestor selection #20336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
commented
Nov 19, 2024
mwtian
reviewed
Nov 20, 2024
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
reviewed
Nov 26, 2024
|
|
||
| // Probe accepted rounds in round prober. | ||
| #[serde(skip_serializing_if = "is_false")] | ||
| consensus_round_prober_probe_accepted_rounds: bool, |
There was a problem hiding this comment.
nit: probably just consensus_round_probe_accepted_rounds would do
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
reviewed
Nov 27, 2024
mwtian
reviewed
Dec 3, 2024
…d anemo is unused
arun-koshy
force-pushed
the
ak/accepted-blocks
branch
from
9b30953 to
24de64c
Compare
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mwtian
reviewed
Dec 4, 2024
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good @arun-koshy ! I am approving but I would suggest for waiting for @mwtian to approve as well.
| // When probe_accepted_rounds is false, should use received rounds | ||
| let network_high_quorum_round = | ||
| ancestor_state_manager.calculate_network_high_quorum_round(); | ||
| assert_eq!(network_high_quorum_round, 300); |
There was a problem hiding this comment.
Why does 300 passes here? I would expect the quorum between the received quorum rounds (100, 229), (225, 229), (229, 300), (229, 300) to be 299
There was a problem hiding this comment.
We are calculating the high quorum round of the high quorum rounds. So based on the values of 229, 229, 300, 300 when we iterate (ascending) the value & stake that is >= the quorum_threshold is 300 and that is essentially the highest round seen by f+1 (2 authorities).
mwtian
approved these changes
Dec 4, 2024
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ancestor selection we want to ensure the highest quality ancestors are included in the proposal, therefore if an authority is excluded we should start including them once they have caught up to the network with their accepted blocks not just received as its possible for blocks to be received but suspended on many hosts which can cause performance degradation
Additionally switched to using high quorum round of the high quorum round of accepted rounds for inclusion metric.
Also bumped protocol version to 70 to include the new feature.
Test plan
How did you test the new or updated feature?
Injected Latency Test - https://metrics.sui.io/goto/Jowh4F7Hg?orgId=1
Hoarded Block Test - Pending
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.