[sui-system package] Set up a staking threshold of 1 SUI #9825
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
| // New exchange rate for validator 2: 660/300 | ||
| // Staker 2 amounts for 0.5 * (660/300 * 100 - 100) + 100 = 160 SUI | ||
| // Validator 2 amounts for 660 - 160 = 500 SUI | ||
| // TODO: Investigate the discrepancy |
There was a problem hiding this comment.
@emmazzz could you please help me with the investigation of this test? I'm not sure but there seems to be a problem with the calculations (my napkin calculations don't match the results)
There was a problem hiding this comment.
Hey @dmitri-perelman if we forget about the whole idea of exchange rate, and just think about how much staker 2 and validator 2 should get, we see that the numbers do match:
- Validator 2 gets her share of the rewards plus half of staker 2's so that's 225 + 105/2 = 277.5 SUI in rewards. And together with the 225 SUI she already has, she gets 225 + 277.5 = 502.5 SUI, which is super close to 502499999999 MIST.
- Staker 2 therefore gets 105 * 1.5 = 157.5 SUI in total.
Now back to looking at the exchange rate, the issue is with the new exchange rate for validator 2. It's not 660/300. When commissions are distributed, they aren't added as rewards to the pool. Instead they are added as new stakes of validators (this way the commission isn't shared with other stakers) to the pool. Also these commissions include commissions on the validator's self stake as well because, remember, validator is simply another staker.
Therefore we did get 0.5 * 30 = 15 more SUI of stake added to the pool the first time and 0.5 * 330 = 165 SUI added the second time. The first time that translated to 15 * (300 / (300 + 15)) = 14.28 pool tokens and the second time that translated to 165 * (314.28 / (330 + 165)) = 104.76 pool tokens. So the number of pool tokens we have in the pool after the second reward distribution is 300 + 14.28 + 104.76 = 419.04. And plugging in the formula we get:
- Staker 2 amounts for 100 * (660 / 419.04) = 157.5
- Validator 2 amounts for 660 - 157.5 = 502.5
There was a problem hiding this comment.
Wow. @emmazzz your math is strong
dmitri-perelman
force-pushed
the
staking_threshold
branch
3 times, most recently
from
be427d4
to
e4d9389
Compare
The threshold is set at the entry level to the Sui system object: the rewards to the validators might still be smaller than the threshold so we can't set it at the level of the staking pool.
dmitri-perelman
force-pushed
the
staking_threshold
branch
from
e4d9389
to
2c656de
Compare
dmitri-perelman
requested review from
randall-Mysten and
ronny-mysten
as code owners
|
@Jordan-Mysten given the new 1 SUI staking limit, how should I update the |
|
Edit: looks like this amount was incremented two days ago to more than 1 SUI. So rebasing should fix the failures already. sui/crates/sui-cluster-test/src/faucet.rs Line 117 in 1594a4a |
## Description Took over the work @dmitri-perelman started (and almost finished) in #9825 because I can't push to his fork of the repo. ## Test Plan Added some tests. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: Dmitri Perelman <dmitrip@Dmitris-MacBook-Pro.local>
The threshold is set at the entry level to the Sui system object: the rewards to the validators might still be smaller than the threshold so we can't set it at the level of the staking pool.
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes