tidy: Move assignments to constructor member initialization list. (ex…

…tra)

Promote member initialization by assignment in the body of the
constructor to be part of the constructor initialization list.  If
possible, further promote these values to default member initializers.

Changes pointed out by clang-tidy and made by hand.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/prefer-member-initializer.html
https://clang.llvm.org/extra/clang-tidy/checks/modernize/pass-by-value.html
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html

.clang-tidy

@@ -147,8 +147,6 @@ Checks: '-*,
         # access unions. https://www.boost.org/ ,
        -cppcoreguidelines-pro-type-union-access,
 
-       -cppcoreguidelines-prefer-member-initializer,
-
         # As of 2024-08-01, there are 110 unique warnings. ,
        -cppcoreguidelines-avoid-const-or-ref-data-members,
 

mythtv/libs/libmythtv/channelscan/paneatsc.h

@@ -20,7 +20,10 @@ class PaneATSC : public GroupSetting
   public:
     PaneATSC(const QString &target, StandardSetting *setting) :
         m_atscTable(new ScanFrequencyTable()),
-        m_atscModulation(new ScanATSCModulation())
+        m_atscModulation(new ScanATSCModulation()),
+        m_transportStart(new TransMythUIComboBoxSetting()),
+        m_transportEnd(new TransMythUIComboBoxSetting()),
+        m_transportCount(new GroupSetting())
     {
         setVisible(false);
 
@@ -30,15 +33,12 @@ class PaneATSC : public GroupSetting
         connect(m_atscModulation, qOverload<const QString&>(&StandardSetting::valueChanged),
                 this,             &PaneATSC::ModulationChanged);
 
-        m_transportStart = new TransMythUIComboBoxSetting();
         m_transportStart->setLabel(tr("First Channel"));
         m_transportStart->setHelpText(tr("Start scanning at this channel."));
 
-        m_transportEnd   = new TransMythUIComboBoxSetting();
         m_transportEnd->setLabel(tr("Last Channel"));
         m_transportEnd->setHelpText(tr("Stop scanning after this channel."));
 
-        m_transportCount = new GroupSetting();
         m_transportCount->setLabel(tr("Channel Count"));
         m_transportCount->setHelpText(tr("Total number of channels to scan."));
         m_transportCount->setReadOnly(true);

mythtv/libs/libmythupnp/mbroadcastsocketdevice.h

@@ -31,7 +31,6 @@ class MBroadcastSocketDevice : public MSocketDevice
         m_address(sAddress), m_port(nPort)
     {
         m_address.setAddress( sAddress );
-        m_port = nPort;
 
         setProtocol(IPv4);
         setSocket(createNewSocket(), MSocketDevice::Datagram);

mythtv/libs/libmythupnp/serializers/soapSerializer.h

@@ -13,6 +13,8 @@
 #ifndef SOAPSERIALIZER_H
 #define SOAPSERIALIZER_H
 
+#include <utility>
+
 #include "upnpexp.h"
 #include "xmlSerializer.h"
 
@@ -29,10 +31,11 @@ class UPNP_PUBLIC SoapSerializer : public XmlSerializer
     public:
 
         SoapSerializer( QIODevice     *pDevice, 
-                        const QString &sNamespace, 
-                        const QString &sRequestName ) : XmlSerializer( pDevice, sRequestName ) 
+                        QString sNamespace,
+                        const QString &sRequestName )
+          : XmlSerializer( pDevice, sRequestName ),
+            m_sNamespace(std::move(sNamespace))
         {
-            m_sNamespace = sNamespace;
         }
 
         ~SoapSerializer() override = default;

mythtv/libs/libmythupnp/upnptaskcache.h

@@ -42,7 +42,6 @@ class SSDPCacheTask : public Task
 
         SSDPCacheTask() : Task("SSDPCacheTask")
         {
-            m_nExecuteCount = 0;
             m_nInterval     = 30s;
 // TODO: Rework when separating upnp/ssdp stack
 //               XmlConfiguration().GetDuration<std::chrono::seconds>("UPnP/SSDP/CacheInterval", 30s);