Skip to content

Commit

Permalink
web-app: Miscellaneous fixes
Browse files Browse the repository at this point in the history
Fix recordings menu bugs from PrimeNG upgrade:
- Sub-menu was off the screen
- Menu was not refreshing when another item was selected

Remove unused import of Slide Menu
Fix color and alignment of links in recording schedule dialog
  • Loading branch information
bennettpeter committed Aug 22, 2024
1 parent afa8b38 commit 7872829
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 9 deletions.
2 changes: 1 addition & 1 deletion mythtv/html/apps/backend/main.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@

:host ::ng-deep .p-tieredmenu .p-submenu-list {
border: 2px solid;
}
left: 10%;
top: 2em;
}
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,11 @@ export class RecordingsComponent implements OnInit {
this.jobs[ix + this.jobsoffset].visible = false;
}
}
// todo: implement this
// todo: implement this ??
// this.menuToShow.push(this.mnu_updaterecrule);

// Notify Angular that menu has changed
this.menuToShow = [...this.menuToShow];
this.menu.toggle(event);
}

Expand Down
2 changes: 0 additions & 2 deletions mythtv/html/backend/src/app/primeng.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import { ProgressBarModule } from 'primeng/progressbar';
import { ScrollPanelModule } from 'primeng/scrollpanel';
import { TabMenuModule } from 'primeng/tabmenu';
import { MultiSelectModule } from 'primeng/multiselect';
import { SlideMenuModule } from 'primeng/slidemenu';
import {InputTextareaModule} from 'primeng/inputtextarea';
import {TieredMenuModule} from 'primeng/tieredmenu';

Expand Down Expand Up @@ -68,7 +67,6 @@ import {TieredMenuModule} from 'primeng/tieredmenu';
ScrollPanelModule,
TabMenuModule,
MultiSelectModule,
SlideMenuModule,
InputTextareaModule,
TieredMenuModule
]
Expand Down
12 changes: 12 additions & 0 deletions mythtv/html/backend/src/app/schedule/schedule.component.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

a:link {
background-color: white;
}

a:visited {
background-color: white;
}

a:active {
background-color: white;
}
8 changes: 4 additions & 4 deletions mythtv/html/backend/src/app/schedule/schedule.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -258,13 +258,13 @@
<div class="form-group field" *ngIf="recRule.Type != 'Recording Template'">
<label for="Inetref" class="label block">{{ 'dashboard.sched.inetref_label' | translate }}</label>
<div class="grid p-0">
<div class="col-3 flex align-items-center">
<div class="col-5 flex align-items-center">
<p-radioButton name="prefix" value="ttvdb4.py_" [(ngModel)]="metaPrefix" inputId="ttvdb"
(ngModelChange)="iCheckbox(recRule)"></p-radioButton>
<label for="ttvdb"><img class="pl-1 " src="images/metadata/thetvdb.png" alt="thtvdb"
height="40"></label>
</div>
<div class="col-9 flex align-items-center">
<div class="col-7 flex align-items-center">
<a href="{{ URLencode('https://thetvdb.com/search?query='+recRule.Title) }}" target="_blank">
{{ 'dashboard.sched.isearch' | translate }} thetvdb.com</a>
<br>
Expand All @@ -280,13 +280,13 @@
{{ 'dashboard.sched.isearch' | translate }} tvmaze.com</a>
<br>
</div>
<div class="col-3 flex align-items-center">
<div class="col-5 flex align-items-center">
<p-radioButton name="prefix" value="tmdb3.py_" [(ngModel)]="metaPrefix" inputId="tmdb"
(ngModelChange)="iCheckbox(recRule)"></p-radioButton>
<label for="tmdb"><img class="pl-1 " src="images/metadata/themoviedb.svg" alt="themoviedb"
height="40"></label>
</div>
<div class="col-9 flex align-items-center">
<div class="col-7 flex align-items-center">
<a href="{{ URLencode('https://www.themoviedb.org/search?query='+recRule.Title) }}"
target="_blank">
{{ 'dashboard.sched.isearch' | translate }} themoviedb.org</a>
Expand Down

0 comments on commit 7872829

Please sign in to comment.