Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music: Some lyrics grabber fail #427

Closed
rcrdnalor opened this issue Dec 8, 2021 · 0 comments · Fixed by #847
Closed

Music: Some lyrics grabber fail #427

rcrdnalor opened this issue Dec 8, 2021 · 0 comments · Fixed by #847
Labels
bug:general General Bugs component:mythtv:metadata Metadata grabber issues

Comments

@rcrdnalor
Copy link
Contributor

rcrdnalor commented Dec 8, 2021

  • Platform: Ubuntu 18.04, 20.04, 21.10

  • MythTV version: v29, v31, master

  • Package version: N/A, self compiled

  • Component: MythMusic

What steps will reproduce the bug?

Run the python scripts located in mythtv/programs/scripts/metadata/Music/lyrics
as described in https://code.mythtv.org/trac/ticket/13545

How often does it reproduce? Is there a required condition?

Always

What is the expected behaviour?

The scripts pass the tests described in above trac ticket.

What do you see instead?

The scripts fail with output listed below

Additional information

This is the follow-up to
https://code.mythtv.org/trac/ticket/13545
and related to the python files in mythtv/programs/scripts/metadata/Music/lyrics.

Over the time, more and more lyrics grabber are failing:

Current status:
Broken, not converted to python3

  • alsong.py
  • baidu.py
  • lyricsmode.py

Converted to python3, tests executed accordin trac ticket:

  • ttplayer : Error: 'urlopen error timed out'
  • lyricswiki : Error: "You're not authorized to access this API."
  • lyricscom : ok
  • genius : Error: "The lyrics for the test search failed!" (*)
  • embedlrc : ok
  • darklyrics : Error: HTTP Error 418: I'm a teapot (**)
  • filelyrics : ok

(*) It seems they changed the API or deleted the access token which MythTV is using
(**) API changed?

According
https://gitlab.com/ronie/script.cu.lrclyrics/-/tree/leia
the grabber 'genius' and 'darklyrics' can be fixed, and
'lyricswiki' and 'ttplayer' are marked as 'broken'.
The status of 'lyricsmode' needs to be evaluated.

@rcrdnalor rcrdnalor added bug:general General Bugs component:mythtv:metadata Metadata grabber issues labels Dec 8, 2021
rcrdnalor added a commit to rcrdnalor/mythtv that referenced this issue Dec 8, 2021
Cleanup imports and additional code for python2.
Fixed lyrics script 'darklyrics.py':
http request: provide required headers and cookie

Please note, that only a subset of the lyrics scripts are functional:
See MythTV#427 for details.

Refs MythTV#422
rcrdnalor added a commit that referenced this issue Dec 20, 2021
Cleanup imports and additional code for python2.
Fixed lyrics script 'darklyrics.py':
http request: provide required headers and cookie

Please note, that only a subset of the lyrics scripts are functional:
See #427 for details.

Refs #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:general General Bugs component:mythtv:metadata Metadata grabber issues
Projects
None yet
1 participant