Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPTV m3u channel importing to insert channels with decimals, such as "2.1" or "23.11" #860

Closed
amessina opened this issue Feb 11, 2024 · 3 comments
Assignees

Comments

@amessina
Copy link

Is your feature request related to a problem? Please describe.
When importing lineup.m3u from a HDHomeRun device, the channel-number field includes channels such as channel-number"2.1". These channels are then created in the database channel table with an integer in the channum column. This makes matching SchedulesDirect lineups difficult (tv_grab_zz_sdjson_sqlite), as channum does not match the <number> output by tv_grab_zz_sdjson_sqlite.

I think this may be because

// Parse extension, HDHomeRun style
casts int channel_number = channum.toInt (&ok); though I can't be sure.

See lineup.m3u.txt

Describe the solution you'd like
I'd like to see the channum column contain the channel-number output from the m3u file.

Describe alternatives you've considered
I run UPDATE channel SET channum=LEFT(callsign,LOCATE(' ',callsign) - 1); before running

tv_grab_zz_sdjson_sqlite --quiet --get-lineup --config-file /etc/mythtv/OTA.xmltv | MythUtil-Channel-XMLTV-getLineup --videosource-id 1 --update --refresh-icons --include-extra-icons

to get SchedulesDirect data to match properly.

@kmdewaal kmdewaal self-assigned this Feb 11, 2024
@kmdewaal
Copy link
Contributor

Yes, I see the problem. This feature was developed and tested with a European HDHomeRun and there the channel numbers are just integers... I think that copying the channel number as a string might just work for both Europe and US. I will have a look at it.

kmdewaal added a commit that referenced this issue Feb 12, 2024
Allow IPTV m3u channel importing from HDHomeRun tuners to insert
channels with decimals, such as "2.1" or "23.11"
The validation of HDHomeRun channel numbers is changed to allow
any non-empty string as channel number instead of only an integer number.

Refs #860
@kmdewaal
Copy link
Contributor

The fix has been tested on a European HDHomeRun and with the lineup.m3u file attached to this ticket but not yet wth a real USA HDHomeRun. The plan is to backport this fix to v34 in a few days when there are no problems reported.

kmdewaal added a commit that referenced this issue Feb 13, 2024
Allow IPTV m3u channel importing from HDHomeRun tuners to insert
channels with decimals, such as "2.1" or "23.11"
The validation of HDHomeRun channel numbers is changed to allow
any non-empty string as channel number instead of only an integer number.

Refs #860

(cherry picked from commit 62ad21b)
@amessina
Copy link
Author

Thanks for such a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants