MythPlayer::HasReachedEof(): short circuit the special cases #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has no functional change, but is clearer logic.
linuxdude42
reviewed
Mar 23, 2022
| if (GetEditMode()) | ||
| return false; | ||
| if (m_liveTV) | ||
| return false; | ||
| if (!m_deleteMap.IsEmpty() && m_framesPlayed >= m_deleteMap.GetLastFrame()) | ||
| return true; | ||
| return false; | ||
| return (GetEof() != kEofStateNone && !m_allPaused); |
There was a problem hiding this comment.
This can return different results than before. Try the combination of eof is kEofStateDelayed, m_allPaused is false, and GetEditMode() is true. Before the change this would return true, after the change it returns false.
There was a problem hiding this comment.
Good point, I'll have to look into it more deeply, but my intuition is that you wouldn't want to exit because of EOF while editing the recording.
It may also make sense to add:
if (GetEof() == kEofStateImmediate)
return true;
I'll investigate further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no functional change, but is clearer logic.