Do not delete IPTV channel in DeleteChannel #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function DeleteChannel does not really delete a channel but marks it for deletion when it is no longer referenced. This is introduced in commit 2e26f7f. Because the channel is not really deleted, as in removed from the database, the associated record in table iptv_channel should also not be deleted here. The chhannel is removed from the database in a periodic housekeeping task when there are no more recordings referencing that channel and when at least one day has passed since the channel was marked for deletion. When the channel is finally deleted then also the corresponding entry in iptv_channel, when it exists, should be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function DeleteChannel does not really delete a channel but marks it for deletion when it is no longer referenced. This is introduced in commit 2e26f7f. Because the channel is not really deleted, as in removed from the database, the associated record in table iptv_channel should also not be deleted here.
The channel is removed from the database in a periodic housekeeping task when there are no more recordings referencing that channel and when at least one day has passed since the channel was marked for deletion.
When the channel is finally deleted then also the corresponding entry in iptv_channel, when it exists, should be deleted.