Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make website responsive on larger displays/viewports #5

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

aryanprince
Copy link
Contributor

@aryanprince aryanprince commented Oct 25, 2024

Changes

  • Add a max-width when on larger/wider viewports
  • Add text balancing to description on hero section

Screenshots

Improved Design for Large Displays

Top (Before): No X-axis margins/padding. Makes it hard to read on large displays (anything over 1080p).
Bottom (After): Added a max-width to the page and the navbar. That's it, but is way easier to read through now.

before
after

Text Balancing

Left (After): Adds text balancing so description looks (much) nicer! Makes it way easier to read as well
Right (Before): Currently how it looks like, has a few 'orphan' words on larger displays that can't fit the entire description on 1 page

image

Known Issue

If you notice, the section background and the website's body background have different colors/gradients. This is the same before (currently) and after this PR cus no changes have been made to the BG colors in this PR.

But it could look more 'pronounced' on larger displays now with this PR's changes. I can open a PR later to make it blend better to the body background, unless this design choice is intentional (no issues then).

image

@vapidinfinity
Copy link
Member

This is huge, dude, thanks.
Was planning on doing this but i don't really know how to webdev so I was relying a bit on Copilot to help me through, lol

As for the 'pronounced' look, the gradient is intentional to denote a change in page content, but returning to the original color in a subtle manner -- lots of apple pages do this tmk.

So, before merging, it'd be preferred if the gradient was the whole viewport wide.

@vapidinfinity vapidinfinity merged commit 2e11594 into MythicApp:main Oct 25, 2024
@vapidinfinity
Copy link
Member

Managed to (hopefully) solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants