Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Commit

Permalink
errors reworked part one (#4)
Browse files Browse the repository at this point in the history
* errors reworked phase one part one

a massive redoing of error messages within dev-loop to actually make
them more user friendly, and actually usable. this isn't complete
but it's getting big enough I want to push it to a WIP PR, to look
through it and potentially catch anything in just the github diff
view I don't already have called out.

by redoing the error messages we've also made the code more correct.
doing things like actually matching on enum values instead of hijacking
the string type, and matching on that.

not to mention fixed bugs where loggers would conflict with the "nice"
task output window.

or fixing the bugs where nothing would output for a long time when
downloading a docker image.

* fix linting

* fix ETXTFILEBUSY error when parallelizing

sometimes when running tasks in parallel the host system can not
spawn multiple bash processes at the same time, and as a result
responds with ETXTFILEBUSY. This would show up as a HostExecutor
failure, specifically with an 10 error code, specifically:

`[Os { code: 26, kind: Other, message: "Text file busy" }]`

Since the "text file busy" text is much less unreliable than the
error code, we now determine if the exit code was text file busy,
for each OS mentioned in the rust documentation, and then if so
respawn the command transparently.

* bump docker version, small msg fixups

* upgrade color-eyre, better log levels

- upgrade `color-eyre` to 0.4.2 so we can properly disable spantraces
  unless requested by the user.
- properly mark warnings as warnings, instead of abusing the
  `error!()` macro logging for something that isn't an immediate
  error.

* color-eyre v0.5.0

* remove unneeded test

remove the test for logging, as it wasn't really that useful, also
it breaks color-eyre's assumptions about loggers.

* first pass on docker error messages reworked
  • Loading branch information
Mythra authored Jul 6, 2020
1 parent 665766a commit 5e7809d
Showing 121 changed files with 3,002 additions and 1,293 deletions.
4 changes: 2 additions & 2 deletions .azure-pipelines/linux-merge.yml
Original file line number Diff line number Diff line change
@@ -27,8 +27,8 @@ steps:
displayName: Build Dev-Loop Release
- script: |
cd ./e2e/
DL_COMMAND="../target/dl-release" ./run-all-tests.sh
cd ./e2e/linux-e2e/
DL_COMMAND="../../target/dl-release" ./run-all-tests.sh
displayName: Validate Dev-Loop Release
- task: PublishPipelineArtifact@1
4 changes: 2 additions & 2 deletions .azure-pipelines/test.yml
Original file line number Diff line number Diff line change
@@ -32,6 +32,6 @@ steps:
./scratch/dl exec build dl-release
displayName: Build Dev-Loop Release
- script: |
cd ./e2e/
DL_COMMAND="../target/dl-release" ./run-all-tests.sh
cd ./e2e/linux-e2e/
DL_COMMAND="../../target/dl-release" ./run-all-tests.sh
displayName: Validate Dev-Loop Release
12 changes: 6 additions & 6 deletions .dl/executors/dl-executors.yml
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ executors:
experimental_permission_helper: 'true'
export_env: 'RUST_BACKTRACE'
extra_mounts: 'scratch/rust-git-cache/:/home/rust/.cargo/git/,scratch/rust-registry-cache/:/home/rust/.cargo/registry/,scratch/rustup-cache/:/home/dl/.rustup/'
image: 'ekidd/rust-musl-builder:1.43.0'
image: 'ekidd/rust-musl-builder:1.43.1'
name_prefix: 'rustc-musl-'
user: 'rust'
provides:
@@ -17,24 +17,24 @@ executors:
- name: linux
- type: docker
params:
image: 'node:12.14'
image: 'node:14.4.0'
name_prefix: 'nodejs-'
provides:
- name: nodejs
version: '12.14.0'
version: '14.4.0'
- name: bash
version: '4.0.0'
- name: linux
- type: docker
params:
image: 'node:12.14'
image: 'node:14.4.0'
name_prefix: 'nodejs-with-port-'
tcp_ports_to_expose: '3000'
provides:
- name: nodejs-with-port
version: '12.14.0'
version: '14.4.0'
- name: nodejs
version: '12.14.0'
version: '14.4.0'
- name: bash
version: '4.0.0'
- name: linux
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
13.6.0
14.4.0
Loading

0 comments on commit 5e7809d

Please sign in to comment.