Skip to content

Commit

Permalink
Move padding to <summary> element.
Browse files Browse the repository at this point in the history
Otherwise the `<details>` element receives the click and doesn't trigger popover.

Co-authored-by: Lee Reilly <lee@github.com>
  • Loading branch information
N1ck and leereilly committed Mar 17, 2022
1 parent 790f092 commit 8641059
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/components/giphy-toolbar-item.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@
import React from 'dom-chef'

export default (
<details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right ghg-trigger btn-octicon p-2 p-md-1 mx-1">
<summary class="menu-target" aria-label="Insert a GIF" aria-haspopup="menu">
<details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right ghg-trigger btn-octicon">
<summary
class="menu-target p-2 p-md-1 mx-1"
aria-label="Insert a GIF"
aria-haspopup="menu"
>
{'GIF'}
</summary>
<details-menu
Expand Down

0 comments on commit 8641059

Please sign in to comment.