Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css selector to append gif toolbar button back #64

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

MinhPhu0304
Copy link
Contributor

@MinhPhu0304 MinhPhu0304 commented Oct 31, 2023

Hello @N1ck, this is just an attempt from me trying to fix this extension. Vend is not the same without it

Github just rolled out a bunch of frontend change and it broke this extension

Proof that it works on my machine

Screenshot 2023-11-01 at 9 42 46 AM

PS I don't know what I'm doing so all feedback are welcomed 😅

Copy link
Owner

@N1ck N1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Just a small change to the selector but great investigative work 👏

src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
@N1ck knows better than me on this I trust him

Co-authored-by: Nick Lockhart <nicko@canva.com>
@MinhPhu0304 MinhPhu0304 requested a review from N1ck October 31, 2023 22:43
@MinhPhu0304
Copy link
Contributor Author

Thanks for that, just applied suggestion. I can soon use gif again 🥳

@N1ck N1ck merged commit 484fa96 into N1ck:master Oct 31, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants