Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorized example C-API #61

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Vectorized example C-API #61

merged 5 commits into from
Jan 10, 2024

Conversation

scarrazza
Copy link
Contributor

No description provided.

@scarrazza scarrazza marked this pull request as ready for review November 15, 2023 11:55
@scarrazza
Copy link
Contributor Author

This should be ready, even if I don't like the way we update the fortran array.

@scarlehoff
Copy link
Member

What do you mean?

But you are going to confuse people using a 0-based array in Fortran! :P

@scarlehoff
Copy link
Member

scarlehoff commented Nov 30, 2023

I've tested it in linux and updated the readme and a few minor things (like NNPDF3.1 -> NNPDF4.0) and a typo in cffi. LGTM.

These examples won't work easily in Apple Silicon, see e.g., pygfx/wgpu-py#190 but I honestly don't think it's that important (and the burden is on installing cffi in a way that it works I guess).

@scarlehoff scarlehoff linked an issue Nov 30, 2023 that may be closed by this pull request
@scarlehoff scarlehoff merged commit 7653610 into master Jan 10, 2024
2 checks passed
@scarlehoff scarlehoff deleted the vectorized_example branch January 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to query (x,Q) arrays in the C/Fortran examples
2 participants