Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehicle drop off restrictions #329

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Add vehicle drop off restrictions #329

merged 4 commits into from
Sep 3, 2021

Conversation

josee-sabourin
Copy link
Contributor

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

As discussed in issue #270, there is no way to describe how a vehicle should be returned at the end of a trip.

What is the proposal?

This proposal adds a return_type field to vehicle_types.json that allows operators to define if the vehicle is free_floating (vehicle must be returned anywhere within the service area), roundtrip (vehicle must be returned at original rental station), or station (vehicle must be returned to any station within the service area). The field is modelled as an array to account for hybrid vehicles that have multiple ways of being returned.

Additionally, to account for edge cases where a vehicle must be returned to a particular station that is not the original station, a home_station field has been added to free_bike_status.json.

Read the full extension proposal here.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

  • vehicle_types.json
  • free_bike_status.json

Adds 1 field to vehicle_types.json (3 enums)
Adds 1 field to free_bike_status.json
Copy link

@kanagy kanagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal!

gbfs.md Outdated Show resolved Hide resolved
josee-sabourin and others added 2 commits June 22, 2021 09:07
Renames fields station -> any_station,
roundtrip -> roundtrip_station
Adds clarification on which enums can be defined together.
Points to rules in geofencing_zones.json for free_floating vehicles.
@kanagy
Copy link

kanagy commented Jun 23, 2021

Hello! I'd love to hear about aggregators / transportation apps on needs assessment in #270, specifically (sorry to be late):

  • Are there any aggregators currently that already support hybrid systems (as described in the doc)? If so how are they currently represented in the feeds and does this proposal work for you?
  • Is there an interest to support A to A systems, e.g. bike rental shops? This is a curious use case for transportation apps (built for getting from A to B); it would mean surfacing these it as a viable option for an A to B routes but then somehow cautioning that a user needs to get back to A eventually.

@viestat
Copy link
Contributor

viestat commented Aug 13, 2021

Hello!

Is there any intention to merge this PR?
This PR along with #349 are needed in order to resolve the need outlaid in #332.

Thanks!

@mplsmitch
Copy link
Collaborator

@viestat In order to merge this PR it needs to be voted on. We'll be calling a vote as soon as we've got the necessary support lined up. In order to pass we need at least 3 votes including one from a data producer and one from a data consumer. Would you be willing to support this as the data producer?

Full governance/change process is here

@heidiguenin heidiguenin added proposal:nonbreaking v2.3 Candidate change for v2.3 (minor release) labels Aug 16, 2021
@viestat
Copy link
Contributor

viestat commented Aug 18, 2021

Would you be willing to support this as the data producer?

@mplsmitch thank you for clarifying, I am willing to support it.

@josee-sabourin
Copy link
Contributor Author

josee-sabourin commented Aug 23, 2021

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on September 1st, 2021.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

EDIT: Tagging for previous engagement in issue/google docs - @hbruch @leonardehrenfried @flaktack @viestat

@kanagy
Copy link

kanagy commented Aug 23, 2021

Google Maps supports this proposal. We don't intend on immediately supporting it, but think this will be useful in the future to model increasingly hybrid systems.

I think minor changes would be useful in this PR:

  1. Renaming return_types to return_constraints seems more accurate. It makes it clear that these are optional constraints that when defined routing apps should respect.
  2. Optionally, adding any_charging_station as a constraint after Add field to designate stations that support vehicle charging #340 PR is in.

@testower
Copy link
Contributor

Entur supports this proposal and will implement it in our aggregation service.

@nbdh
Copy link
Contributor

nbdh commented Aug 26, 2021

Nextbike supports this proposal. As such limitations are rather scarce in our systems publishing this field probably won't have priority for us.

@NicolasFrasie
Copy link

Communauto supports this proposal. It is required to specify if a vehicle is round-trip for GBFS to be able to model round trip carsharing (such as Communauto and Modo in Canada, Zipcar and Enterprise CarShare in US, Citiz in France, etc.).

This PR is a prerequisite for PR #350 which aims to extend the current GBFS specification to allow car sharing support (roundtrip like Zipcar, free-floating like GIG CarShare and station-to-station like BlueLA)

@viestat
Copy link
Contributor

viestat commented Aug 27, 2021

Dott supports this proposal, however we will not implement this until #349 (or any alternative proposal that fully addresses #332) is merged.

@Miryad3108
Copy link
Contributor

The French national access point to transport data transport.data.gouv.fr supports this proposal which has been integrated into the PR #350

@evansiroky
Copy link
Contributor

IBI Group supports this proposal, although we recommend renaming free_bike_status.json#home_station to free_bike_status.json#home_station_id to try to follow a naming convention that shows which fields have IDs as values.

@kanagy
Copy link

kanagy commented Aug 31, 2021

+1 for renaming to home_station to home_station_id for consistency with other fields

@cait32
Copy link

cait32 commented Sep 1, 2021

BCycle supports this proposal, but will not implement it immediately.

@ncancelliere
Copy link

Spin supports this proposal. We don’t plan on immediately supporting it.

@ezmckinn
Copy link
Contributor

ezmckinn commented Sep 1, 2021

Superpedestrian supports this proposal, but like @viestat noted, would not implement until #349 is merged.

@josee-sabourin
Copy link
Contributor Author

This vote is now closed, and it passes!

Votes in favour:
Google Maps (consumer)
Entur (consumer)
Nextbike (producer)
Communauto (producer)
Dott (producer)
Transport.data.gouv.fr (consumer)
IBI Group (consumer)
BCycle (producer)
Spin (producer)
Superpedestrian (producer)

Regarding @kanagy's and @evansiroky's comments: We will make the semantic changes once we merge into v2.3-RC. Regarding any_charging_station, we will open an issue to determine the need for this field.

@mplsmitch mplsmitch merged commit 3e7902b into master Sep 3, 2021
@heidiguenin heidiguenin mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md proposal:nonbreaking v2.3 Candidate change for v2.3 (minor release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.