Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge localdata #135

Merged
merged 7 commits into from
Apr 14, 2022
Merged

Merge localdata #135

merged 7 commits into from
Apr 14, 2022

Conversation

ZhiXuanLai
Copy link
Contributor

Considering if the conditional for MD5 download is required, or we can simplify the code and always download the MD5 file

@ZhiXuanLai ZhiXuanLai requested a review from mpoelchau April 11, 2022 13:08
@mpoelchau
Copy link
Contributor

@ZhiXuanLai this looks pretty good! I made a few edits to the .yml file and pushed them. My only other comment is that in the gene prediction readme, the protein fasta file has quotation marks and brackets around it - perhaps this is due to removing the array/scatter for this?

The following files were retrieved from NCBI on 2022-12-4:
https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/001/298/625/GCF_001298625.1_SEUB3.0/GCF_001298625.1_SEUB3.0_genomic.gff.gz
https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/001/298/625/GCF_001298625.1_SEUB3.0/GCF_001298625.1_SEUB3.0_cds_from_genomic.fna.gz
https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/001/298/625/GCF_001298625.1_SEUB3.0/GCF_001298625.1_SEUB3.0_rna_from_genomic.fna.gz
["https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/001/298/625/GCF_001298625.1_SEUB3.0/GCF_001298625.1_SEUB3.0_translated_cds.faa.gz"]

@mpoelchau mpoelchau merged commit 8b8c6dd into master Apr 14, 2022
@mpoelchau mpoelchau deleted the merge-localdata branch April 14, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants