Thanks for taking the time to consider contributing! We very much appreciate your time and effort. This document outlines the many ways you can contribute to our project, and provides detailed guidance on best practices. We look forward to your help!
Before you begin contributing to our project, it'll be a good idea to ensure you've satisfied the below pre-requisites.
To accept your contributions for any kind of patch, you'll want to:
- Understand what a Developer Certificate of Origin is. See this guide.
- Read and agree to the terms of the Developer Certificate of Origin.
- Remember to add your Sign-Off for each patch contribution you submit to our project via either:
- By using the
-sflag if using Git. See these instructions. - By including the following text in your patch contributions (i.e. pull requests)
Signed-off-by: Full Name <email> - By using the
Reviewers reviewing your patch will look for the sign-off before deciding to accept your contribution.
Our project has our licensing terms, including rules governing redistribution, documented in our LICENSE file. Please take a look at that file and ensure you understand the terms. This will impact how we, or others, use your contributions.
Our Code of Conduct helps facilitate a positive interaction environment for everyone involved with the team, and provides guidance on what to do if you experience problematic behavior. Read more in our CODE_OF_CONDUCT.md, and make sure you agree to its terms.
Our Governance model helps outline our project's decision making and roles-based expectations. Read more in our GOVERNANCE.md.
For patch contributions, see our Developer Documentation for more details on how to set up your local environment, to best contribute to our project.
At a minimum however to submit patches (if using Git), you'll want to ensure you have:
- An account on the Version Control System our project uses (i.e. GitHub).
- The Version Control System client (i.e. Git) installed on your local machine.
- The ability to edit, build, and test our project on your local machine. Again, see our README.md or detailed developer guide for more details
Before contributing changes to our project, it's a great idea to be familiar with our communication channels and to socialize your potential contributions to get feedback early. This will help give you context for your contributions, no matter their form.
Our communication channels are:
- Issue tracking system - a regularly monitored area to report issues with our software or propose changes
- Discussion board - a permanently archived place to hold conversations related to our project, and to propose as well as show+tell topics to the contributor team. This resource can be searched for old discussions.
- Slack: #mipl
Our project integrates contributions from many people, and so we'd like to outline a process you can use to visualize how your contributions may be integrated if you provide something.
flowchart TD
repo_proj[(Our Repository)]-->|Fork|repo_fork[(Your Forked Repository)]
repo_fork-->|Make|patch(Your Changes)
patch-->|Submit|pr(Pull Request)
pr==>|Approved|repo_proj
pr-->|Changes Requested|repo_fork
Forking our repository, as opposed to directly committing to a branch is the preferred way to propose changes.
See this GitHub guide on forking for information specific to github.com
Make sure people are aware you're working on a patch! Check out our issue tracking system and find an open issue you'd like to work against, or alternatively file a new issue and mention you're working on a patch.
Our project typically has the following branches available, make sure to fork either the default branch or a branch someone else already tagged with a particular issue ticket you're working with.
develop— default branch, used for new code developmentmaster— release branch
Within your local development environment, this is the stage at which you'll propose your changes, and commit those changes back to version control. See the README.md or development guide for more specifics on what you'll need as prerequisites to setup your local development environment.
Commit messages to version control should reference a ticket in their title / summary line:
Issue #248 - Show an example commit message title
This makes sure that tickets are updated on GitHub with references to commits that are related to them.
Commit should always be atomic. Keep solutions isolated whenever possible. Filler commits such as "clean up white space" or "fix typo" should be merged together before making a pull request, and significant sub-feature branches should be rebased to preserve commit history. Please ensure your commit history is clean and meaningful!
Additionally, remember to "Sign-Off" on your commits to align with our Developer Certificate of Origin (DCO) policy.
Pull requests are the core way our project will receive your patch contributions. Navigate to your branch on your own fork within the version control system, and submit a pull request or submit the patch text to our project.
Please make sure to provide a meaningful text description to your pull requests, whenever submitted. Our pull-request template will be auto-generated for you when you create your pull-request. See the template here.
Working on your first Pull Request? See guide: How to Contribute to an Open Source Project on GitHub
Reviewing pull-requests, or any kinds of proposed patch changes, is an art. That being said, we follow the following best practices:
- Intent - is the purpose of your pull-request clearly stated?
- Solution - is your pull-request doing what you want it to?
- Correctness - is your pull-request doing what you want it to correctly?
- Small Patches - is your patch of a level of complexity and brevity that it can actually be reviewed by a human being? Or is does it involve too much content for one pull request?
- Coding best practices - are you following best practices in the coding / contribution language being used?
- Readability - is your patch readable, and ultimately maintainable, by others?
- Reproducibility - is your patch reproducible by others?
- Tests - do you have or have conducted meaningful tests?
Do you like to talk about new features, changes, requests?
Issue tickets are a very simple way to get involved in our project. It also helps new contributors get an understanding of the project more comprehensively. This is a great place to get started with the project if you're not sure where to start.
See our list of issues at: https://github.jpl.nasa.gov/MIPL/VICAR/issues
Often we receive duplicate issues that can confuse project members on which issue ticket to hold conversations upon.
Here's how you can help:
- Scan the list of open issue tickets for duplicate titles, or internal wording
- If you find duplicates, copy / paste the below message on the conversation thread of the issue ticket that has less participants involved
This is a duplicate issue. Please migrate conversations over to [issue-XYZ](hyperlink to issue)
Issue tickets can vary in complexity, and issues labeled with good first issue labels are often a great way to get started with the project as a newcomer.
Take a look at our issue tracking system, and filter by good first issue for issues that are low-complexity, and that will help you get familiar with our issue tracking and patch submission process.
Labels within our issue tracking system are a great way to quickly sort through tickets. The project may not yet have labels to cover the full variety of issue tickets. Take a look through our list of issues, and if you notice a set of issue tickets that seem similar but are not categorized with an existing label, go ahead submit a request within one of the issues you've looked at with the following text:
I've noticed several other issues that are of the same category as this issue. Shall we make a new label for these types of issues?
Resolving bugs is a priority for our project. We welcome bug reports. However, please make sure to do the following prior to submitting a bug report:
- Check for duplicates - there may be a bug report already describing your issue, so check the issue tracking system first.
Here's some guidance on submitting a bug issue:
- Navigate to our issue tracking system and file a new issue
- Select a bug template (if available) for your issue
- Fill out the template fields to the best of your ability, including output snippets or screenshots where applicable
- Follow the general guidelines below for extra information about your bug
- Include a code snippet if you have it showcasing the bug
- Provide reproducible steps of how to recreate the bug
- If the bug triggers an exception or error message, include the full message or stacktrace
- Provide information about your operating system and the version of our project you're using
We welcome new feature requests to help grow our project. However, please make sure to do the following prior to submitting a new feature request:
- Check for duplicates - there may be a new feature issue already describing your issue, so check the issue tracking system first
- Consider alternatives - is your feature really needed? Or is there a feature within our project or with a third-party that may help you achieve what you want?
Here's some guidance on submitting a new feature issue:
- Navigate to our issue tracking system and file a new issue
- Select a new feature template (if available) for your issue
- Fill out the template fields to the best of your ability
Security vulnerabilities should not be filed to the regular issue tracking system.
Report your security vulnerabilities to (see contact links): @jleach or @jpon
Please be sure to:
- Indicate the severity of the vulnerability
- Provide any workarounds, if you know them
- Provide return-contact information to follow-up with you if needed
Reviewing others' contributions is a great way to learn about best practices in both contributions as well as software.
Take a look at our pull requests tracking system, and try the following options for providing a review:
- Read the code / patch associated with the pull-request, and take note of any coding, bug, or documentation issues if found
- Try to recreate the pull-request patch on your local machine, and report if it has issues with your system in particular
- Scan over suggested feedback from other contributors, and provide feedback if necessary
- Check if any duplicate issues exist that cover your code contribution idea / task, and add comments to those tickets with your thoughts.
- If no duplicates exist, create a new issue ticket and get a conversation started before making code changes using our communication channels.
Once you have a solid issue ticket in hand and are ready to work on code, you'll want to:
- Ensure you have development prerequisites cleared.
- Have your development environment set up properly.
- Go through our development process, including proposing changes to our project.
Some guidelines for code-specific contributions:
- Do your homework - read-up on necessary documentation, like
README.mds, developer documentation, and pre-existing code to see the intention and context necessary to make your contribution a success. It's important to communicate what you're working on through our project communication channels and get buy-in from frequent contributors - this will help the project be more receptive to your contributions! - Ask questions - its important to ask questions while you work on your contributions, to check-in with frequent contributors on the style and the set of expectations to make your code contribution work well with pre-existing project code. Use our communication channels
- Keep positive - code contributions, by their nature, have direct impacts on the output and functionality of the project. Keep a positive spirit as your code is reviewed, and take it in stride if core contributors take time to review, give you suggestions for your code or respectfully decline your contribution. This is all part of the process for quality open source development.
- Comments - include useful comments throughout your code that explain the intention of a code block, not a step-by-step analysis. See our inline code documentation section for specifics.
Documentation is the core way our users and contributors learn about the project. We place a high value on the quality, thoroughness, and readability of our documentation. Writing or editing documentation is an excellent way to contribute to our project without performing active coding.
- Check if any duplicate issues exist that cover your documentation contribution idea / task, and add comments to those tickets with your thoughts.
- If no duplicates exist, create a new issue ticket and get a conversation started before making documentation changes.
Some guidelines for documentation best practices (summarized from Google's excellent documentation guide):
- Minimum viable docs - don't do less documentation than your users / developers need, but also don't do more
- Changed code = changed docs - if your code has changed, remember to update your documentation
- Delete old docs - continually clean your documentation tree, and remove outdated docs regularly
The overall structure of our project documentation is as follows:
- Source-controlled documentation
- README.md - top-level information about how to run, build, and contribute to the project
- CODE_OF_CONDUCT.md - best practices and guidance on how to work well with other people in the project, and suggestions on dealing with interpersonal issues
- CONTRIBUTING.md - guidance on contributing to the project
*.java- inline documentation available inside code files
- Hosted documentation
- Discussion Boards
For directions on contributing to our source-controlled documentation:
- Ensure you have development prerequisites cleared.
- Have your development environment set up properly.
- Go through our development process, including proposing changes to our project.
To ensure documentation is readable and consistent by newcomers and experts alike, here are some suggestions on writing style for English:
- Use gender neutral pronouns (they/their/them) instead of he/she/his/her
- Avoid qualifiers that minimize the difficulty of a task at hand, e.g. avoid words like “easily”, “simply”, “just”, “merely”, “straightforward”, etc. Readers' expertise may not match your own, and qualifying complexity may deter some readers if the task does not match their level of experience. That being said, if a particular task is difficult or complex, do mention that.
Below are some commonly used words you'll want to leverage in your documentation contributions:
- AMMOS - Advanced Multi-Mission Operations System tool set.
- Artifactory - Lab-based artifact repository that stores compiled builds for reuse.
- GitHub - One word with capitalization of the 'G' and 'H'.
- Jenkins - Continuous Integration (CI) server that hosts many Lab builds.
- MIPL - Multimission Instrument Processing Lab which hosts the project containing this repository.
- VICAR Java Build - The build system that collects and compiles related code.
For language-specific guidance on code documentation, including style guides, see Google's list of language style guides for a variety of languages.
Additionally, take a look at Google's recommendations on inline code documentation for best practices.
Media, such as images, videos, sound files, etc., are an excellent way to explain documentation to a wider audience more easily. Include media in your contributions as often as possible.
When including media into our version-control system, it is recommended to use formats such as:
- Diagrams: Mermaid format
- Images: JPEG format
- Videos: H264 MPEG format
- Sounds: MP3 format
Answering questions is an excellent way to learn more about our project, as well as get better known in our project community.
Here are just a few ways you can help answer questions for our project:
- Answer open questions in our discussion forum
- Answer open questions mentioned in our issue tracking system
When answering questions, keep the following in mind:
- Be polite and friendly. See our Code of Conduct recommendations as you interact with others in the team.
- Repeat the specific question you are answering, followed by your suggestion.
- If suggesting code, repeat the line of code that needs to be altered, followed by your alteration
- Include any post-steps or checks to verify your answer can be reproduced
Design files can help to guide new features and new areas of expansion for our project. We welcome these kinds of contributions.
Here are just a few ways you can help provide design recommendations for our project:
- Create visual mockups or diagrams to increase usability of our project applications. This can apply to user interfaces, documentation structuring, or even code architecture diagrams.
- Conduct user research to understand user needs better. Save your findings within spreadsheets that the project team / contributors can review.
- Create art, such as logos or icons, to support the user experience for the project
Each of the above can be contributed directly to repository code, and you should use our development process to contribute your additions.
A great way to contribute towards our project goals is to socialize and encourage people to meet and learn more about each other. Consider ideas like:
- Propose workshops or meetups regarding some topic within our project
- Help point project contributors and community members to conferences and publications where they may socialize their unique innovations
- Schedule in-person or virtual happy-hours to help create a more social atmosphere within the project community
For the above ideas, use our communication channels to propose get-togethers.