Address PR issues from Bryan

NASA-AMMOS · Oct 22, 2024 · f547fe9 · f547fe9
1 parent 933ea97
commit f547fe9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/utilities/sequence-editor/from-seq-json.ts b/src/utilities/sequence-editor/from-seq-json.ts
@@ -120,8 +120,8 @@ function seqJsonVariableToSequence(
   sequence += variables
     .map(variable => {
       const name = variable.name;
-      const type = variable.type ? ' ' + variable.type : '';
-      const enumName = variable.enum_name ? ' ' + variable.enum_name : '';
+      const type = variable.type ? ` ${variable.type}` : '';
+      const enumName = variable.enum_name ? ` ${variable.enum_name}` : '';
       const allowableRanges = variable.allowable_ranges
         ? ` "${variable.allowable_ranges.map(range => `${range.min}...${range.max}`).join(',')}"`
         : '';

diff --git a/src/utilities/sequence-editor/to-seq-json.ts b/src/utilities/sequence-editor/to-seq-json.ts
@@ -567,8 +567,10 @@ function parseAllowableRanges(text: string, rangeNode: any): { max: number; min:
       const rangeMatch = /^([-+]?\d+)?(\.\.\.)([-+]?\d+)?$/.exec(range.replaceAll('"', '').trim());
       if (rangeMatch) {
         const [, min, , max] = rangeMatch;
-        const maxNum = !isNaN(Number(max)) ? Number(max) : Infinity;
-        const minNum = !isNaN(Number(min)) ? Number(min) : -Infinity;
+        const parsedMaxNum = Number(max);
+        const parsedMinNum = Number(min);
+        const maxNum = !Number.isNaN(parsedMaxNum) ? parsedMaxNum : Infinity;
+        const minNum = !Number.isNaN(parsedMinNum) ? parsedMinNum : -Infinity;
 
         return { max: maxNum, min: minNum };
       }