Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile fetching failure toast #1108

Merged
merged 6 commits into from
Feb 17, 2024
Merged

Conversation

AaronPlave
Copy link
Contributor

Show toast on profile and external profile fetching failure. Closes #1105.

Testing:

  1. Load a plan
  2. Temporarily modify the GQL GET_PROFILES and GET_PROFILES_EXTERNAL to be invalid.
  3. Refresh the plan
  4. Toasts should appear alerting you that profile fetching failed

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! merging for 2.4.0 release.

@dandelany dandelany merged commit 6203bec into develop Feb 17, 2024
4 checks passed
@dandelany dandelany deleted the fix/1105/profile-fetch-fail-toast branch February 17, 2024 00:25
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Toast safety

* Show failure toast if resource or external resource queries fail

* Make sure external resource loading indicator is reset properly

* Make toasts test safe

---------

Co-authored-by: Dan Delany <dan.delany@gmail.com>
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Toast safety

* Show failure toast if resource or external resource queries fail

* Make sure external resource loading indicator is reset properly

* Make toasts test safe

---------

Co-authored-by: Dan Delany <dan.delany@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error displayed if GetProfiles query fails
3 participants