Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simulation template padding #1198

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix simulation template padding #1198

merged 3 commits into from
Mar 29, 2024

Conversation

lklyne
Copy link
Contributor

@lklyne lklyne commented Mar 28, 2024 •
edited by AaronPlave
Loading

  • Remove the custom left margin causing simulation template to be cut off on the left side.
  • Swap the hover state for a parameter to have a top and bottom border instead of a box shadow. Not necessary for the above change, but this is more extensible if we want to change the overflow of the container in the future.

image

Closes #1163

@lklyne lklyne requested a review from a team as a code owner March 28, 2024 23:41
@lklyne lklyne requested review from AaronPlave, duranb and joswig March 28, 2024 23:41
duranb
duranb approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lklyne lklyne requested a review from duranb March 28, 2024 23:46
AaronPlave
AaronPlave approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Honestly no idea how long ago that negative margin was needed.. glad it is gone!

@lklyne lklyne force-pushed the fix-simulation-template-padding branch from 2aa3647 to 1d84d2d Compare March 28, 2024 23:54
@AaronPlave AaronPlave force-pushed the fix-simulation-template-padding branch from 1d84d2d to 5847602 Compare March 29, 2024 14:58
@AaronPlave AaronPlave merged commit 0392524 into develop Mar 29, 2024
4 checks passed
@AaronPlave AaronPlave deleted the fix-simulation-template-padding branch March 29, 2024 15:04
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@lklyne
Fix simulation template padding (#1198)
e0b140b 
* swap box shadow for top and bottom borders
* remove custom margin for simulation template
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@lklyne @JosephVolosin
Fix simulation template padding (#1198)
d4a48b8 
* swap box shadow for top and bottom borders
* remove custom margin for simulation template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@duranb duranb Awaiting requested review from duranb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searchable dropdown left padding
3 participants
@lklyne @AaronPlave @duranb