form editor, disabled download button, nested grid which may have roo… #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m for improvement
joswig
requested review from
cohansen
and removed request for
dandelany,
AaronPlave and
duranb
…, warning cleanup
…dded some suggested fixes
cohansen
pushed a commit
that referenced
this pull request
May 9, 2024
#1213) * form editor, disabled download button, nested grid which may have room for improvement * filter codemirror edit dispatching * remove redundant quotes on metadata and model values * leave whitespace when addining missing args, fix for missing time tag, warning cleanup * demonstration of quick fix actions on arg counts (#1214) * made grammar more flexible with directive ordering and misspelling, added some suggested fixes * cleaned up some diagnostic actions * lint @Locals and @INPUT_PARAMETERS
duranb
pushed a commit
that referenced
this pull request
May 17, 2024
#1213) * form editor, disabled download button, nested grid which may have room for improvement * filter codemirror edit dispatching * remove redundant quotes on metadata and model values * leave whitespace when addining missing args, fix for missing time tag, warning cleanup * demonstration of quick fix actions on arg counts (#1214) * made grammar more flexible with directive ordering and misspelling, added some suggested fixes * cleaned up some diagnostic actions * lint @Locals and @INPUT_PARAMETERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dandelany @duranb @AaronPlave we are still a ways from asking to merge this into develop, but if you see anything that will make that easier feel free to suggest it early