Feature/parameter and channel dict upload #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarted adding support for uploading parameter and channel dictionaries
…xed a problem with the seq page not loading
joswig
requested review from
cohansen
and removed request for
a team,
dandelany,
AaronPlave and
duranb
goetzrrGit
requested changes
Apr 22, 2024
goetzrrGit
reviewed
Apr 22, 2024
goetzrrGit
approved these changes
Apr 24, 2024
cohansen
added a commit
that referenced
this pull request
May 9, 2024
* Moved sequence adaptation uploading to the command dictionary page, started adding support for uploading parameter and channel dictionaries * Fixed issues with uploading command dictionaries and sequence adaptations * Added support for parsing channel and parameter dictionaries * Fixed an issue with uploading a parameter dictionary * Fixed the form builder from showing on the sequence select screen, fixed a problem with the seq page not loading * First pass at adding parcels * Changed sequence editing to use parcels rather than command dictionaries * Hooked up sequence adaptation id to parcels * Added support for a single parameter dictionary * link adaptation code up with parcel * editor is readonly in table view * content assist uses adaptation * check unclosed blocks * annotate all parser errors * variable names, but not types are checked * better detection of command on selection line * code style * cleaned up some commented out print statements * cleaned up some commented out print statements * reduce block nesting and remove obsolete commented code * Some code cleanup * use symbol for all enum type arguments --------- Co-authored-by: Cody Hansen <codyhansen92@gmail.com>
duranb
pushed a commit
that referenced
this pull request
May 17, 2024
* Moved sequence adaptation uploading to the command dictionary page, started adding support for uploading parameter and channel dictionaries * Fixed issues with uploading command dictionaries and sequence adaptations * Added support for parsing channel and parameter dictionaries * Fixed an issue with uploading a parameter dictionary * Fixed the form builder from showing on the sequence select screen, fixed a problem with the seq page not loading * First pass at adding parcels * Changed sequence editing to use parcels rather than command dictionaries * Hooked up sequence adaptation id to parcels * Added support for a single parameter dictionary * link adaptation code up with parcel * editor is readonly in table view * content assist uses adaptation * check unclosed blocks * annotate all parser errors * variable names, but not types are checked * better detection of command on selection line * code style * cleaned up some commented out print statements * cleaned up some commented out print statements * reduce block nesting and remove obsolete commented code * Some code cleanup * use symbol for all enum type arguments --------- Co-authored-by: Cody Hansen <codyhansen92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.