Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new env var modues from Svelte Kit #71

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

camargo
Copy link
Member

@camargo camargo commented Jul 27, 2022

  • Update code to use new env var modules provided by Svelte Kit
  • Remove obsolete /env endpoint for loading env vars
  • Remove obsolete env store
  • Add .env file for default public dynamic env vars
  • Add PublicEnv interface for declaring the public env vars
  • Use vite preview for running production build so .env is used for e2e tests
  • See: feat: Consistent handling of environment variables sveltejs/kit#5663

- Update code to use new env var modules provided by Svelte Kit
- Remove obsolete /env endpoint for loading env vars
- Remove obsolete env store
- Add .env file for default public dynamic env vars
- Add PublicEnv interface for declaring the pubic env vars
- Use vite preview for running production build so .env is used for e2e tests
- See: sveltejs/kit#5663
@camargo camargo requested a review from patkenneally as a code owner July 27, 2022 16:47
@camargo camargo requested review from AaronPlave, duranb and jeffpamer and removed request for patkenneally July 27, 2022 16:47
@camargo camargo merged commit df056fa into develop Jul 27, 2022
@camargo camargo deleted the refactor/use-new-env-var-modules branch July 27, 2022 17:14
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
- Update code to use new env var modules provided by Svelte Kit
- Remove obsolete /env endpoint for loading env vars
- Remove obsolete env store
- Add .env file for default public dynamic env vars
- Add PublicEnv interface for declaring the pubic env vars
- Use vite preview for running production build so .env is used for e2e tests
- See: sveltejs/kit#5663
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
- Update code to use new env var modules provided by Svelte Kit
- Remove obsolete /env endpoint for loading env vars
- Remove obsolete env store
- Add .env file for default public dynamic env vars
- Add PublicEnv interface for declaring the pubic env vars
- Use vite preview for running production build so .env is used for e2e tests
- See: sveltejs/kit#5663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants