Handle 'null' values when deserializing for command expansion #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
added
bug
goetzrrGit
changed the title
goetzrrGit
requested review from
mattdailis and
dandelany
and removed request for
cohansen and
adrienmaillard
mattdailis
approved these changes
Feb 29, 2024
mattdailis
force-pushed
the
pass_through_null_expansion
branch
from
504a33f
to
288da88
Compare
Establishing a default behavior to gracefully handle schemas with null values. Instead of encountering server-side errors that disrupt sequence expansion, null values will now be implicitly passed through. This decision places the onus on the expansion logic to implement appropriate null checks and handle potential null cases accordingly.
mattdailis
force-pushed
the
pass_through_null_expansion
branch
from
288da88
to
f388aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Establishing a default behavior to gracefully handle schemas with null values. Instead of encountering server-side errors that disrupt sequence expansion, null values will now be implicitly passed through. This decision places the onus on the expansion logic to implement appropriate null checks and handle potential null cases accordingly.
Future work
Find a better way to allow for an OptionalValueMapper with the ValueMapperSchema