AERIE-2041 - TS convert functional programing UNIT to {}

[goetzrrGit]

• Tickets addressed: AERIE-2041
• Review: By commit
• Merge strategy: Merge (no squash)

Description

In the mission model, the activity's effect model that doesn't return a computed attribute (aka void run() method of the activity) uses UNIT which represents a non-null empty value. This is used internally by AERIE

https://en.wikipedia.org/wiki/Unit_type

This UNIT value will be exposed to our users when command authoring. Our users are not functional programmers so this causes confusion.

This will change the computed attribute to {} which makes more sense to the user.

Verification

Ran the command expansion test locally without any issues

Documentation

None

Future work

None

[Twisol]

(I might be jumping the gun a bit on this review; sorry if so.)

[goetzrrGit]

I learned a lot from this ticket. Now I found the code-gen part of Merlin. This gets propagated down to the command expansion part now and will show up as:

declare global {
	interface ThrowBanana {
		readonly type: 'ThrowBanana';
		readonly duration: Temporal.Duration;
		readonly startOffset: Temporal.Duration;
		readonly startTime: Temporal.Instant;
		readonly endTime: Temporal.Instant;
		readonly attributes: {
			readonly arguments: {
				readonly speed: number;
			}
			readonly computed: {
			};
		}
	}
	type ActivityType = ThrowBanana;
}

export {};